Skip to content

[HOLD for payment 2024-04-29][$250] Share log - Chat icon is highlighted in Settings after returning from share destination #39926

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: new feature
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Settings > About > Troubleshoot.
  3. Enable "Client side logging".
  4. Click View console debug.
  5. Click Share log.
  6. Select any share destination.
  7. Tap on the back button until app returns to Settings page.

Expected Result:

When returning to Settings page, the profile icon should be highlighted.

Actual Result:

When returning to Settings page, the chat icon is highlighted.
When clicking on profile icon, app reopens the same settings page.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6443177_1712647546277.Screen_Recording_20240409_151204_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01bd717be733d9cef5
  • Upwork Job ID: 1777700496702263296
  • Last Price Increase: 2024-04-09
  • Automatic offers:
    • DylanDylann | Reviewer | 0
    • bernhardoj | Contributor | 0

Activity

  1. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 9, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. kbecciv commented on Apr 9, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. amyevans commented on Apr 9, 2024

    @amyevans
    Contributor

    Not a blocker

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 9, 2024
  6. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 9, 2024
  8. 25 remaining items

  9. melvin-bot commented on Apr 16, 2024

    @melvin-bot

    📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  10. bernhardoj commented on Apr 17, 2024

    @bernhardoj
    Contributor

    PR is ready

    cc: @DylanDylann

  11. alexpensify commented on Apr 17, 2024

    @alexpensify
    Contributor

    Heads up, I will be offline until Tuesday, April 23, 2024, and will not actively watch over this GitHub during that period.

    If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

  12. alexpensify commented on Apr 23, 2024

    @alexpensify
    Contributor

    I checked in and it looks like this PR was merged yesterday. Now, let's wait for automation to kick in.

  13. amyevans commented on Apr 24, 2024

    @amyevans
    Contributor

    Hmm it was deployed to production already which is when the automation should post, so it seems like that failed. I'll update the title manually - due for payment 7 days after 4/22 so 4/29.

  14. changed the title [-][$250] Share log - Chat icon is highlighted in Settings after returning from share destination[/-] [+][HOLD for payment 2024-04-29][$250] Share log - Chat icon is highlighted in Settings after returning from share destination[/+] on Apr 24, 2024
  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    ReviewingHas a PR in review
    on Apr 24, 2024
  16. alexpensify commented on Apr 26, 2024

    @alexpensify
    Contributor

    Thanks! Noted for April 29.

  17. alexpensify commented on Apr 29, 2024

    @alexpensify
    Contributor

    Payouts due: April 29, 2024

    Upwork job is here.

  18. alexpensify commented on Apr 29, 2024

    @alexpensify
    Contributor

    Closing - the list above has been paid via Upwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions