Skip to content

Expense - Report field is not removed when deleted #39919

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.61-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #36039
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • User is an employee of Collect workspace.
  • The Collect workspace has some report fields.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a manual request.
  4. Go to expense report.
  5. Click on the report field > Add value > Save it.
  6. On Old Dot, as admin, delete the report field in Step 5.
  7. As employee, go to main chat and back to expense report (to receive update).
  8. Click on the deleted report field.
  9. Click 3-dot menu > Delete > Delete the field.

Expected Result:

The report field will be removed

Actual Result:

The report field is not removed. It is only removed after clearing cache and restart from Troubleshooting section.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6443123_1712642141246.36039_desktop.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dc85d44bb737c556
  • Upwork Job ID: 1777733234423984128
  • Last Price Increase: 2024-04-09

Activity

  1. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 9, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. kbecciv commented on Apr 9, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. mountiny commented on Apr 9, 2024

    @mountiny
    Contributor
  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 9, 2024
  6. mountiny commented on Apr 9, 2024

    @mountiny
    Contributor

    This is not a deploy blocker as report fields are not really used in NewDot by customers yet its a new feature for Newdot

    @allroundexperts @thienlnam could you help with this one?

  7. added
    InternalRequires API changes or must be handled by Expensify staff
    on Apr 9, 2024
  8. melvin-bot commented on Apr 9, 2024

    @melvin-bot
  9. melvin-bot commented on Apr 9, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

  10. thienlnam commented on Apr 9, 2024

    @thienlnam
    Contributor

    I believe this has to do with the pusher updates from oldDot not getting prefixed with expensify_ . I can take this

  11. melvin-bot commented on Apr 12, 2024

    @melvin-bot

    @allroundexperts, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. thienlnam commented on Apr 12, 2024

    @thienlnam
    Contributor

    The fix PR should be live now - need to retest

  13. melvin-bot commented on Apr 15, 2024

    @melvin-bot

    @allroundexperts, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. melvin-bot commented on Apr 16, 2024

    @melvin-bot

    @allroundexperts, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

  15. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    @allroundexperts, @thienlnam Huh... This is 4 days overdue. Who can take care of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions