Skip to content

[HOLD for payment 2024-07-17][$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight #39909

Closed
Closed
[HOLD for payment 2024-07-17][$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight#39909
Assignees
abekkalarushatgabhanegrgiatienifr
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@izarutskaya
izarutskaya
opened on Apr 9, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.61-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #38674
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat.
  3. Go offline.
  4. Type @ and search for user that shows the fallback avatar in offline mode.
  5. Use keyboard key to highlight the selection.

Expected Result:

The background of the fallback avatar should be visible when the user with fallback avatar is highlighted in the suggestion list.

Actual Result:

The background of the fallback avatar has the color as the selection highlight, so the background appears invisible when it is highlighted. This issue occurs in both light and dark mode.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6443096_1712637992454.20240409_123616.mp4
Bug6443096_1712637992472!Screenshot_2024-04-09_at_12 40 27

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017d901ad4a12b6e9e
  • Upwork Job ID: 1777661865535434752
  • Last Price Increase: 2024-04-09
  • Automatic offers:
    • tienifr | Contributor | 0
    • eh2077 | Contributor | 102899881
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. izarutskaya
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 9, 2024

  2. melvin-bot commented on Apr 9, 2024

    @melvin-bot
    melvin-botbot
    on Apr 9, 2024 – with Melvin Bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot
    assigned
    abekkala
    and
    Beamanator
    on Apr 9, 2024

  4. melvin-bot commented on Apr 9, 2024

    @melvin-bot
    melvin-botbot
    on Apr 9, 2024 – with Melvin Bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Apr 9, 2024

  6. github-actions commented on Apr 9, 2024

    @github-actions
    github-actionsbot
    on Apr 9, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  7. izarutskaya commented on Apr 9, 2024

    @izarutskaya
    izarutskaya
    on Apr 9, 2024
    Author

    @abekkala I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  8. izarutskaya commented on Apr 9, 2024

    @izarutskaya
    izarutskaya
    on Apr 9, 2024
    Author

    We think this issue might be related to the #vip-vsb.

  9. izarutskaya commented on Apr 9, 2024

    @izarutskaya
    izarutskaya
    on Apr 9, 2024
    Author

    Production

    Recording.2359.mp4

  10. tienifr commented on Apr 9, 2024

    @tienifr
    tienifr
    on Apr 9, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The background of the fallback avatar has the color as the selection highlight, so the background appears invisible when it is highlighted. This issue occurs in both light and dark mode.

    What is the root cause of that problem?

    Fallback icon is updated in this PR to support theme. That cause this issue

    What changes do you think we should make in order to solve the problem?

    This issue is not happen in other list like search page, so we should do the same for more consistency

    Update background color of focused suggestion here like what we did with sidebar link here

    What alternative solutions did you explore? (Optional)

    NA

    Result

    Screenshot 2024-04-09 at 18 12 43

  11. 74 remaining items

  12. melvin-bot
    changed the title [-][HOLD for payment 2024-07-17] [$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight[/-] [+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight[/+] on Jul 15, 2024

  13. melvin-bot commented on Jul 15, 2024

    @melvin-bot
    melvin-botbot
    on Jul 15, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-22. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jul 15, 2024

    @melvin-bot
    melvin-botbot
    on Jul 15, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
    • [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rushatgabhane] Determine if we should create a regression test for this bug.
    • [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

  15. abekkala commented on Jul 16, 2024

    @abekkala
    abekkala
    on Jul 16, 2024
    Contributor

    PAYMENT SUMMARY FOR JULY 17

    • Fix: @tienifr [$250, if no regressions] payment via NewDot
    • PR Review: @rushatgabhane [$250, if no regressions] payment via NewDot
  16. abekkala
    changed the title [-][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight[/-] [+][HOLD for payment 2024-07-22][$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight[/+] on Jul 16, 2024
  17. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jul 16, 2024
  18. abekkala
    changed the title [-][HOLD for payment 2024-07-22][$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight[/-] [+][HOLD for payment 2024-07-17][$250] Fallback avatar- The background of fallback avatar has the same color as selection highlight[/+] on Jul 18, 2024

  19. abekkala commented on Jul 18, 2024

    @abekkala
    abekkala
    on Jul 18, 2024
    Contributor

    This was not a regression - ready for payment!

  20. abekkala commented on Jul 18, 2024

    @abekkala
    abekkala
    on Jul 18, 2024
    Contributor

    PAYMENT SUMMARY FOR JULY 17

  21. melvin-bot
    added
    Overdue
    on Jul 22, 2024
  22. abekkala
    closed this as completedon Jul 22, 2024
  23. melvin-bot
    removed
    Overdue
    on Jul 22, 2024

  24. JmillsExpensify commented on Jul 22, 2024

    @JmillsExpensify
    JmillsExpensify
    on Jul 22, 2024
    Contributor

    $250 approved for @rushatgabhane

  25. JmillsExpensify commented on Jul 25, 2024

    @JmillsExpensify
    JmillsExpensify
    on Jul 25, 2024
    Contributor

    $250 approved for @tienifr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions