Repository navigation
Tax and tax amount are updated little bit delayed in transaction thread page. #39804
Description
Activity
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@laurenreidexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think this issue might be related to the #collect project.
- added and removed
on Apr 8, 2024 Not ideal, but this doesn't need to be a deploy blocker. Checked it off
Reacted by Vivek KumarProposal
Please re-state the problem that we are trying to solve in this issue.
Tax and tax amount are updated in a little bit delayed way in transaction thread page.
What is the root cause of that problem?
We don't pass the
taxCodeandtaxAmounttogetMoneyRequestInformationfunction to build the optimistic transaction sotaxandtaxAmountare only displayed when theRequestMoneyAPI is completeLine 2079 in ce06355
What changes do you think we should make in order to solve the problem?
We should accept passing
taxCodeandtaxAmountintogetMoneyRequestInformationfunction and use it to build the optimistic transaction. So thetaxandtaxAmountcan be displayed immediately when the request is created.What alternative solutions did you explore? (Optional)
NA
@Julesssss What do you think about my proposal? I can raise the PR to fix this issue ASAP if my proposal is selected.
@laurenreidexpensify and @techievivek will perform initial triage before we open it up for contributors, but that shouldn't take long 👍
Reacted by nkdengineer and Vivek KumarDupe of #39615
Reacted by Vivek KumarGreat, going to close it out then, thanks.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.60-13
Reproducible in staging?: Y
Reproducible in production?: Unable to check
Found when executing PR : #39638
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
User is an employee of Collect workspace that has taxes.Set few tax rates 5%, 10%,0% etc
4.Quickly go to transaction thread
Expected Result:
Tax and tax amount must be updated without delay in transaction thread page.
Actual Result:
Tax and tax amount are updated in a little bit delayed way in transaction thread page.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6440019_1712389315629.poooo.mp4
View all open jobs on GitHub