Skip to content

[Pay 4/29][$250] [Track Tax] Error on Amount and Merchant field after changing tax rate when scanning is ongoing #39699

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-8
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • User is an employee of Collect workspace.
  • The Collect workspace has several tax rates.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a scan request and include a tax rate.
  4. When scanning is in progress, go to transaction thread.
  5. Click Tax rate and change to a different tax rate.

Expected Result:

No error on Amount and Merchant field will show up after changing the tax rate.

Actual Result:

Error on Amount and Merchant field shows up briefly after changing the tax rate when scnaning is ongoing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6438765_1712290267104.20240405_120557.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011d90b50207f85d2f
  • Upwork Job ID: 1777350902764363776
  • Last Price Increase: 2024-04-08
  • Automatic offers:
    • cubuspl42 | Reviewer | 0
    • tienifr | Contributor | 0

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 5, 2024
  2. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions commented on Apr 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    @adelekennedy I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 5, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. 55 remaining items

  8. mallenexpensify commented on May 1, 2024

    @mallenexpensify
    Contributor

    @adelekennedy , thanks for double checking. This was an edge case (and/or a mistake on my part), I've paid @cubuspl42 for this outside of this issue. I checked to box above,

    @lakchote , @adelekennedy @tienifr do we want a regression test for this?

  9. melvin-bot commented on May 3, 2024

    @melvin-bot

    @lakchote @adelekennedy @tienifr this issue is now 4 weeks old, please consider:

    • Finding a contributor to fix the bug
    • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
    • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

    Thanks!

  10. lakchote commented on May 6, 2024

    @lakchote
    Contributor

    @lakchote , @adelekennedy @tienifr do we want a regression test for this?

    I think a regression test can't hurt to prevent this from happening in the future and ensuring a smooth user experience.

  11. adelekennedy commented on May 6, 2024

    @adelekennedy
    Contributor

    Then to close this out @tienifr will you suggest a regression test and I can create an issue for it?

  12. mvtglobally commented on May 6, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  13. adelekennedy commented on May 8, 2024

    @adelekennedy
    Contributor

    bump @tienifr for the test steps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions