Skip to content

[HOLD for payment 2024-04-15] [$250] Distance - Only map displayed in distance receipt if only one expense in report #39679

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

precondition: user a member of a workspace, there are no open reports

  1. Open the app and log in
  2. Tap the FAB > Request money > Distance
  3. Enter the start and end points
  4. Select the workspace chat and request money
  5. Open the report
  6. Tap the distance receipt thumbnail

Expected Result:

The map and the expense details including amount, miles, start and end point, and date are displayed

Actual Result:

Only a map is displayed in the receipt when only one transaction is in the report.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6438408_1712260833726.video_2024-04-04_15-59-19.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 5, 2024
  2. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Apr 5, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Apr 5, 2024

    @m-natarajan
    Author

    @robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. m-natarajan commented on Apr 5, 2024

    @m-natarajan
    Author

    We think this bug might be related to #wave-collect - Release 1

  7. Christinadobrzyn commented on Apr 5, 2024

    @Christinadobrzyn
    Contributor

    I don't think this is happening anymore. After reproducing the issue once, the distance receipt now shows the receipt details (see video)

    2024-04-05_12-33-09.mp4

    Also to note: the distance receipt is different from the SmartScan receipt, is that expected?

    I'll ask QA to test again.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 5, 2024
  9. 14 remaining items

  10. mountiny commented on Apr 5, 2024

    @mountiny
    Contributor

    fix is being CPed

  11. mountiny commented on Apr 5, 2024

    @mountiny
    Contributor
    image

    Fixed I think we can close as the PR was handled for another issue

  12. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 5, 2024
  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 8, 2024
  14. changed the title [-][$250] Distance - Only map displayed in distance receipt if only one expense in report[/-] [+][HOLD for payment 2024-04-15] [$250] Distance - Only map displayed in distance receipt if only one expense in report[/+] on Apr 8, 2024
  15. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts] Determine if we should create a regression test for this bug.
    • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions