You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-15] [$250] Distance - Only map displayed in distance receipt if only one expense in report #39679
Version Number: 1.4.60-5 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
precondition: user a member of a workspace, there are no open reports
Open the app and log in
Tap the FAB > Request money > Distance
Enter the start and end points
Select the workspace chat and request money
Open the report
Tap the distance receipt thumbnail
Expected Result:
The map and the expense details including amount, miles, start and end point, and date are displayed
Actual Result:
Only a map is displayed in the receipt when only one transaction is in the report.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][$250] Distance - Only map displayed in distance receipt if only one expense in report[/-][+][HOLD for payment 2024-04-15] [$250] Distance - Only map displayed in distance receipt if only one expense in report[/+]on Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
[@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@allroundexperts] Determine if we should create a regression test for this bug.
[@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Apr 5, 2024
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 5, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Apr 5, 2024
@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
m-natarajan commentedon Apr 5, 2024
We think this bug might be related to #wave-collect - Release 1
Christinadobrzyn commentedon Apr 5, 2024
I don't think this is happening anymore. After reproducing the issue once, the distance receipt now shows the receipt details (see video)
2024-04-05_12-33-09.mp4
Also to note: the distance receipt is different from the SmartScan receipt, is that expected?
I'll ask QA to test again.
14 remaining items
mountiny commentedon Apr 5, 2024
fix is being CPed
mountiny commentedon Apr 5, 2024
Fixed I think we can close as the PR was handled for another issue
[-][$250] Distance - Only map displayed in distance receipt if only one expense in report[/-][+][HOLD for payment 2024-04-15] [$250] Distance - Only map displayed in distance receipt if only one expense in report[/+]melvin-bot commentedon Apr 8, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: