[Ready for C+ checklist and payment][$250] Split - Group chat does not show bill creator name in LHN preview after refreshing the page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Request money > Manual
3. Create a split bill with two users
4. Once landed in group chat, note that group chat in LHN shows the bill creator name in the preview
5. Refresh the page

Expected Result:

The group chat will continue to show the bill creator name in LHN preview after refreshing the page

Actual Result:

The group chat does not show the bill creator name in LHN preview after refreshing the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6438312_1712255589440.20240405_023013.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0126a3e7c5e2856078
• Upwork Job ID: 1777107502133911552
• Last Price Increase: 2024-04-28
• Automatic offers:
• eh2077 | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The LHN subtitle shows the sender name when creating the split bill, but then it disappears.

What is the root cause of that problem?

When we refresh/wait for a moment, we will get the correct response from the BE and the sender name disappears is already correct because we don't want to show the sender name if it's coming from ourself.

App/src/libs/OptionsListUtils.ts

Lines 529 to 533 in 2995f2c

	function getLastActorDisplayName(lastActorDetails: Partial<PersonalDetails> | null, hasMultipleParticipants: boolean) {
	return hasMultipleParticipants && lastActorDetails && lastActorDetails.accountID !== currentUserAccountID
	? // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	lastActorDetails.firstName || PersonalDetailsUtils.getDisplayNameOrDefault(lastActorDetails)
	: '';

The logic to show the sender name is, by taking the report lastActorAccountID and getting the user data from the ID.

App/src/libs/SidebarUtils.ts

Line 297 in 2995f2c

let lastActorDetails: Partial<PersonalDetails> | null = report.lastActorAccountID && personalDetails?.[report.lastActorAccountID] ? personalDetails[report.lastActorAccountID] : null;

However, when we create a split bill, the lastActorAccountID is 0, so the user detail is empty.

App/src/libs/ReportUtils.ts

Line 3781 in 2995f2c

lastActorAccountID: 0,

If it's empty, we will get it from the last report action person data which contains the user display name.

App/src/libs/SidebarUtils.ts

Lines 299 to 307 in 2995f2c

	if (!lastActorDetails && visibleReportActionItems[report.reportID]) {
	const lastActorDisplayName = visibleReportActionItems[report.reportID]?.person?.[0]?.text;
	lastActorDetails = lastActorDisplayName
	? {
	displayName: lastActorDisplayName,
	accountID: report.lastActorAccountID,
	}
	: null;
	}

Because 0 is not the same as the current user ID, the current user display name is shown as the sender.

What changes do you think we should make in order to solve the problem?

Set the lastActorAccountID optimistically to currentUserAccountID when creating a split bill (and revert it when fails). We did this when adding a message/task too.

We might need to do this for other money request too.

What alternative solutions did you explore? (Optional)

1. Don't show the display name when the lastActorAccountID is 0.

OR

2. If we always want to show the sender name, we need to remove the accountID check (lastActorDetails.accountID !== currentUserAccountID) here.
   

   App/src/libs/OptionsListUtils.ts

   Lines 536 to 537 in 9a6cafc

   	function getLastActorDisplayName(lastActorDetails: Partial<PersonalDetails> | null, hasMultipleParticipants: boolean) {
   	return hasMultipleParticipants && lastActorDetails && lastActorDetails.accountID !== currentUserAccountID

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0126a3e7c5e2856078

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)