Repository navigation
[HOLD for Payment 2024-05-30][$500] mWeb - Chat - @ here highlight is removed if you also @phone number #39620
Description
Activity
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.@laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
- changed the title
[-]mWeb - Chat - Here highlighted is removed after selecting an phone number[/-][+]mWeb - Chat - @here highlight is removed if you also @phone number[/+]on Apr 5, 2024 Job added to Upwork: https://www.upwork.com/jobs/~01875c053a0be9f2e8
- changed the title
[-]mWeb - Chat - @here highlight is removed if you also @phone number[/-][+][$250] mWeb - Chat - @here highlight is removed if you also @phone number[/+]on Apr 5, 2024 Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)- changed the title
[-][$250] mWeb - Chat - @here highlight is removed if you also @phone number[/-][+][$250] mWeb - Chat - @ here highlight is removed if you also @phone number[/+]on Apr 5, 2024 42 remaining items
@adriancova is there an ETA on a PR yet? Thanks
Hey @laurenreidexpensify sorry I was out the past couple of days. I'll send the first pr later today.
Reacted by Laurenbump @adriancova
Reacted by Adrian Covarrubias- changed the title
[-][$500] mWeb - Chat - @ here highlight is removed if you also @phone number[/-][+][HOLD for Payment 2024-05-30][$500] mWeb - Chat - @ here highlight is removed if you also @phone number[/+]on May 28, 2024 Payment Summary:
- C+ @mollfpr $500 offered in upwork
- Contributor @adriancova $500 offered in upwork
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:Couldn't find the offending PR.
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
I think the regression step should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.- Open a chat
- Type mention "
@here" - Verify it highlighted
- Type mention a user with the phone number
- Verify that the mention "
@here" and the phone number is highlighted - 👍 or 👎
@laurenreidexpensify I'll do manual request in NewDot, thank you!
Reacted by LaurenPayment Summary:
- C+ @mollfpr $500 will submit a manual request in newdot
- Contributor @adriancova $500 paid in upwork
$500 approved for @mollfpr
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.60
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4479302
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Here highlighted must not be removed after selecting an phone number
Actual Result:
Here highlighted is removed after selecting an phone number
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6438062_1712240881918.here.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit