[$250] Chat - Selected members disappear from search result after returning from confirmation page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.60-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Start chat > Chat
3. Search for a term that will return two users
4. Click Add to group for these two users
5. Click Next without clearing the search field
6. Return to previous page

Expected Result:

The chat page will display the selected members because the search field is not cleared

Actual Result:

The chat page displays "No results found" instead of showing the selected members after returning from group confirmation page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437927_1712233915147.chat_search.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013254e490a0ba9b6d
• Upwork Job ID: 1779812903951724544
• Last Price Increase: 2024-04-15
• Automatic offers:
• s77rt | Reviewer | 0
• tienifr | Contributor | 0

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selected members disappear from search result after returning from confirmation page

What is the root cause of that problem?

We don't pass includeSelectedOptions as true when using getFilteredOptions. Also we don't save keyForList which is essential to show the option as selected when searched.

What changes do you think we should make in order to solve the problem?

We need to pass includeSelectedOptions as true and need to follow few steps to save the keyForList in Onyx.

App/src/pages/NewChatPage.tsx

Line 222 in 93e9719

true,

1. Modify the SelectedParticipant type
   

   App/src/types/onyx/NewGroupChatDraft.ts

   Lines 1 to 4 in 51af342

   	type SelectedParticipant = {
   	accountID: number;
   	login: string;
   	};

   
   To:

type SelectedParticipant = {
    accountID: number;
    login: string;
    keyForList?: string;
};

2. Add keyForList in selectedParticipants array objects.
   

   App/src/pages/NewChatPage.tsx

   Line 196 in 581b5d5

   const selectedParticipants: SelectedParticipant[] = selectedOptions.map((option: OptionData) => ({login: option.login ?? '', accountID: option.accountID ?? -1}));

        const selectedParticipants: SelectedParticipant[] = selectedOptions.map((option: OptionData) => ({
            login: option.login ?? '',
            accountID: option.accountID ?? -1,
            keyForList: option.keyForList ?? undefined,
        }));

3. Return the object with keyForList.
   

   App/src/pages/NewChatPage.tsx

   Line 67 in 581b5d5

   return {...baseOption, reportID: baseOption.reportID ?? ''};

{...baseOption, reportID: baseOption.reportID ?? '', keyForList: participant.keyForList};

Result

selected_participants_dissapear.mp4

Optionally

We can also modify getParticipantsOption to return keyForList if participant object have it.

[Krishna2323]

Proposal updated

• Added POC and optionals

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@muttmuure 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013254e490a0ba9b6d