Repository navigation
[HOLD for payment 2024-05-08] [$250] Profile - Display name is not updating in "Share Somewhere" section #39607
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:
- Go to Profile.
- Add or change the Display name.
- Use FAB to assign a task.
- Add a title and click "Next" to share somewhere.
- Notice that the Display name isn't updated for the account email (email signed in).
Expected Result:
When the Display name is changed, it should be updated in the "Share Somewhere" section for the account email (email signed in).
Actual Result:
Display name is not updating in "Share Somewhere" section
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6437941_1712234508566.Screen_Recording_2024-04-04_at_1.14.37_AM.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0109207e4c67cd7686
- Upwork Job ID: 1776016111925432320
- Last Price Increase: 2024-04-11
- Automatic offers:
- hungvu193 | Reviewer | 0
- nkdengineer | Contributor | 0
Activity
melvin-bot commentedon Apr 4, 2024
Triggered auto assignment to @bondydaa (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kbecciv commentedon Apr 4, 2024
We think that this bug might be related to #vip-vsb
bondydaa commentedon Apr 4, 2024
I'm looking into this, nothing in the checklist stands out to me that might be something that broke this so having to dive into the code and see what exactly gets called.
bondydaa commentedon Apr 4, 2024
okay i don't think it's a problem with the API, i see the response coming back properly with the updated data
And I see in the onyx db that it's been updated there
So this makes me think that for some reason the
Share Somewherecomponent isn't properly subscribing to the onyx data or something so going to take a closer look at that.bondydaa commentedon Apr 4, 2024
Hmm this PR is sus to me after looking at the components involved here: #38207
bondydaa commentedon Apr 4, 2024
okay yes I believe I've confirmed this by testing locally.
checking out
1.4.60-1locally I see the same behavior and then reverting it I can't reproduce it anymore.cc @grgia @hungvu193 @TMisiukiewicz can you take a look here?
bondydaa commentedon Apr 4, 2024
I guess what we need is a way to invalidate the option list cache when personal details are updated, if there is a way to do that in the PR can you let me know?
or if that's still to come then maybe we consider this not a blocker?
makes me think of my favorite tweet 😂 https://twitter.com/codinghorror/status/506010907021828096
jasperhuangg commentedon Apr 4, 2024
@bondydaa This seems like a pretty minor bug–and since we've already narrowed down which PR it's coming from I think we can just mark it NAB and have @TMisiukiewicz look into a fix
52 remaining items
[-][$250] Profile - Display name is not updating in "Share Somewhere" section[/-][+][HOLD for payment 2024-05-08] [$250] Profile - Display name is not updating in "Share Somewhere" section[/+]melvin-bot commentedon May 1, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 1, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-05-08. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 1, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
hungvu193 commentedon May 1, 2024
This is new feature, we can treat it as a follow up of #38207
melvin-bot commentedon May 13, 2024
@JmillsExpensify, @bondydaa, @hungvu193, @nkdengineer Huh... This is 4 days overdue. Who can take care of this?
hungvu193 commentedon May 14, 2024
Bump @JmillsExpensify for payment here
JmillsExpensify commentedon May 14, 2024
Payment summary:
JmillsExpensify commentedon May 14, 2024
Both Contributor contracts paid out via Upwork, so I'm closing this issue.