Skip to content

Taxes - System message for tax amount edit shows USD first, then changes to correct currency #39605

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • The Collect workspace has taxes.
  • The default workspace currency is not USD.
  1. Go to staging.new.expensify.com
  2. Go to Collect workspace chat.
  3. Create a manual request with tax in non-USD currency.
  4. Go to transaction thread.
  5. Click Tax amount.
  6. Edit the amount and save it.

Expected Result:

The system message for tax amount edit will show the correct tax currency.

Actual Result:

The system message for tax amount edit shows the tax in USD first, then changes to the correct currency.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437929_1712233917202.tax_system_message.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0177cce5def94cedf6
  • Upwork Job ID: 1775991223827992576
  • Last Price Increase: 2024-04-04

Activity

  1. melvin-bot commented on Apr 4, 2024

    @melvin-bot

    Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. kbecciv commented on Apr 4, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  3. MonilBhavsar commented on Apr 4, 2024

    @MonilBhavsar
    Contributor

    This can be demoted from deploy blocker. Not a major issue. Feel free to assign it to me. Happy to handle it.
    We can handle as a regression from #33927

  4. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 4, 2024
  5. melvin-bot commented on Apr 4, 2024

    @melvin-bot
  6. melvin-bot commented on Apr 4, 2024

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

  7. melvin-bot commented on Apr 4, 2024

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  8. added
    ReviewingHas a PR in review
    and removed on Apr 5, 2024
  9. MonilBhavsar commented on Apr 5, 2024

    @MonilBhavsar
    Contributor

    PR is up for review!

  10. MonilBhavsar commented on Apr 5, 2024

    @MonilBhavsar
    Contributor

    PR is merged! No further action required here

  11. melvin-bot commented on Apr 29, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @sakluger, @MonilBhavsar eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffMonthlyKSv2ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions