Repository navigation
[HOLD for payment 2024-04-15] BNP - Unable to enter number on BNP unless the number 0.00 is erased first #39599
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to FAB > Request money > Manual.
- Enter any number.
Expected Result:
User should be able to enter number without erasing the number first on BNP.
Actual Result:
User is unable to enter number on BNP unless the number 0.00 is erased first.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Apr 4, 2024
Triggered auto assignment to @iwiznia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
kbecciv commentedon Apr 4, 2024
We think that this bug might be related to #wave-collect - Release 1
dragnoir commentedon Apr 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
Offended PR #35797
issue here: 8e80ffb
What changes do you think we should make in order to solve the problem?
The initial amount shoud be 0 and not 0.00
App/src/pages/iou/steps/MoneyRequestAmountForm.tsx
Line 130 in 0b2f55f
iwiznia commentedon Apr 4, 2024
Going to revert the offending PR
iwiznia commentedon Apr 4, 2024
Not a blocker anymore since we reverted the PR here #39610
melvin-bot commentedon Apr 4, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
11 remaining items
melvin-bot commentedon Apr 5, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]BNP - Unable to enter number on BNP unless the number 0.00 is erased first[/-][+][HOLD for payment 2024-04-15] BNP - Unable to enter number on BNP unless the number 0.00 is erased first[/+]melvin-bot commentedon Apr 8, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
melvin-bot commentedon Apr 15, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Apr 17, 2024
@iwiznia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!