[HOLD for Payment [2024-05-16][$250] Feature Request: Desktop app: Clicking on `update` button shouldn't lead to re download it

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Problem:

on the Mac Desktop app, have this "update" button update the current app directly, instead of leading you to re-download it.

Solution:

User should be able to update without downloading again

Context/Examples/Screenshots/Notes:

Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712096487518269

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c264c5555e17f971
• Upwork Job ID: 1777186397013553152
• Last Price Increase: 2024-04-08
• Automatic offers:
• DylanDylann | Reviewer | 0
• gijoe0295 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Feature Request: Desktop app: Clicking on update button shouldn't lead to re download it

What is the root cause of that problem?

Currently we only open desktop app download link:

App/src/libs/actions/AppUpdate/updateApp/index.desktop.ts

Line 5 in 207385a

Linking.openURL(CONST.APP_DOWNLOAD_LINKS.DESKTOP);

What changes do you think we should make in order to solve the problem?

We should replace the above by:

App/src/components/UpdateAppModal/index.desktop.tsx

Line 9 in 67aadf2

window.electron.send(ELECTRON_EVENTS.START_UPDATE);

We already handle the update event in electron:

App/desktop/main.ts

Line 211 in d22957d

ipcMain.on(ELECTRON_EVENTS.START_UPDATE, quitAndInstallWithUpdate);

By this, the app would restart to install the update automatically.

We also need to update the prompt text accordingly.

What alternative solutions did you explore? (Optional)

NA

[Christinadobrzyn]

I think this can be external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c264c5555e17f971

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)