Skip to content

[$250] Scan - Replace receipt option is present when request is still scanning in one transaction view #39494

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468886
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat that has no unsettled request.
  3. Create a scan request
  4. While the scanning is ongoing, click on the receipt.
  5. Click 3-dot menu.
  6. Note that Replace option is present.
  7. Create a second scan request.
  8. Click 3-dot menu.
  9. Note that Replace option is actually not present for request that is still scanning.

Expected Result:

In Step 5, there should not be Replace option for the request that is still scanning.

Actual Result:

In Step 5, Replace receipt option is available for the request that is still scanning. Clicking on it leads to not here page. This only happens when there is one transaction.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436635_1712143969929.bandicam_2024-04-03_19-28-07-637.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d008a7eab4bb0c77
  • Upwork Job ID: 1775595658777747456
  • Last Price Increase: 2024-04-10
  • Automatic offers:
    • shubham1206agra | Contributor | 0

Activity

  1. melvin-bot commented on Apr 3, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. kbecciv commented on Apr 3, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  3. amyevans commented on Apr 3, 2024

    @amyevans
    Contributor

    This seems like a rather minor bug coming out of the One Transaction View feature, so going to demote it to not block deploy and open it up for proposals. cc @NikkiWines though for visibility, in case you disagree or have any context to add!

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 3, 2024
  5. changed the title [-]Scan - Replace receipt option is present when request is still scanning in one transaction view[/-] [+][$500] Scan - Replace receipt option is present when request is still scanning in one transaction view[/+] on Apr 3, 2024
  6. melvin-bot commented on Apr 3, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 3, 2024
  8. melvin-bot commented on Apr 3, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

  9. 9 remaining items

  10. Santhosh-Sellavel commented on Apr 9, 2024

    @Santhosh-Sellavel
    Collaborator

    @twisterdotcom This some how got missed from my radar. Can you reassign, I can't get to this quicker. Again sorry for the delay

  11. removed their assignment
    on Apr 9, 2024
  12. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 10, 2024
  13. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  14. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 10, 2024
  15. shubham1206agra commented on Apr 10, 2024

    @shubham1206agra
    Contributor

    @twisterdotcom Can you ask QA to retest this?
    This may have been fixed already.

  16. shubham1206agra commented on Apr 10, 2024

    @shubham1206agra
    Contributor

    But @nkdengineer solution is correct (in context passing sense) in some sense. We need to find the bug created if we don't apply the solution.

  17. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  18. izarutskaya commented on Apr 11, 2024

    @izarutskaya

    Not reproduced in latest build
    Build v1.4.62-0

    bandicam.2024-04-11.13-37-45-106.mp4
  19. removed their assignment
    on Apr 11, 2024
  20. shubham1206agra commented on Apr 11, 2024

    @shubham1206agra
    Contributor

    Thanks for the confirmation.
    @twisterdotcom We can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions