Skip to content

[HOLD for payment 2024-04-15] [$250] Send money - IOU preview appears in one transaction report view #39490

Closed
Closed
[HOLD for payment 2024-04-15] [$250] Send money - IOU preview appears in one transaction report view#39490
Assignees
pecanoroparasharrajatstephanieelliottmountiny
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@kbecciv
kbecciv
opened on Apr 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.59-3
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to 1:1 DM.
  3. Click + > Send money.
  4. Send money to the user.
  5. Click on the IOU preview.

Expected Result:

There will not be IOU preview in the one transaction report view (combined report).

Actual Result:

There is an IOU preview in the one transaction report view (combined report), which opens the same transaction thread.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436458_1712132607694.bandicam_2024-04-03_16-20-27-341.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0139f0b6a0758d561f
  • Upwork Job ID: 1775551164535427072
  • Last Price Increase: 2024-04-03
Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. kbecciv
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 3, 2024
  2. melvin-bot
    assigned
    pecanoro
    on Apr 3, 2024

  3. melvin-bot commented on Apr 3, 2024

    @melvin-bot
    melvin-botbot
    on Apr 3, 2024 – with Melvin Bot

    Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions
    added
    Engineering
    HourlyKSv2
    on Apr 3, 2024

  5. github-actions commented on Apr 3, 2024

    @github-actions
    github-actionsbot
    on Apr 3, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  6. kbecciv commented on Apr 3, 2024

    @kbecciv
    kbecciv
    on Apr 3, 2024
    Author

    We think that this bug might be related to #wave-collect - Release 1

  7. mountiny commented on Apr 3, 2024

    @mountiny
    mountiny
    on Apr 3, 2024
    Contributor

    I can help with this one

  8. mountiny
    self-assigned this
    on Apr 3, 2024

  9. mountiny commented on Apr 3, 2024

    @mountiny
    mountiny
    on Apr 3, 2024
    Contributor

    cc @NikkiWines

  10. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    HourlyKSv2
    on Apr 3, 2024

  11. mountiny commented on Apr 3, 2024

    @mountiny
    mountiny
    on Apr 3, 2024
    Contributor

    PR is here #39499

  12. mountiny
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 3, 2024

  13. 19 remaining items

  14. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Apr 8, 2024
  15. melvin-bot
    changed the title [-][$250] Send money - IOU preview appears in one transaction report view[/-] [+][HOLD for payment 2024-04-15] [$250] Send money - IOU preview appears in one transaction report view[/+] on Apr 8, 2024

  16. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botbot
    on Apr 8, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot
    removed
    ReviewingHas a PR in review
    on Apr 8, 2024

  18. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botbot
    on Apr 8, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

  19. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botbot
    on Apr 8, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat] Determine if we should create a regression test for this bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  20. parasharrajat commented on Apr 9, 2024

    @parasharrajat
    parasharrajat
    on Apr 9, 2024
    Member

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. Go to staging.new.expensify.com
    2. Go to 1:1 DM.
    3. Click + > Send money.
    4. Send money to the user.
    5. Click on the IOU preview.
    6. Verify there is no Request action preview shown in the report history when there was only one send money request.

    Do you agree 👍 or 👎 ?

  21. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 14, 2024

  22. melvin-bot commented on Apr 15, 2024

    @melvin-bot
    melvin-botbot
    on Apr 15, 2024 – with Melvin Bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@stephanieelliott)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1775551164535427072/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  23. stephanieelliott commented on Apr 15, 2024

    @stephanieelliott
    stephanieelliott
    on Apr 15, 2024
    Contributor

    This is ready for payment via ND, see summary: #39490 (comment)

  24. stephanieelliott
    closed this as completedon Apr 15, 2024

  25. parasharrajat commented on Jun 14, 2024

    @parasharrajat
    parasharrajat
    on Jun 14, 2024
    Member

    Payment requested as per #39490 (comment)

  26. JmillsExpensify commented on Jun 17, 2024

    @JmillsExpensify
    JmillsExpensify
    on Jun 17, 2024
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions