Repository navigation
[Payment due April 30th] [$500] Expense - Request disappears when deleted offline and there are two requests #39462
Description
Activity
Triggered auto assignment to @marcaaron (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
We think that this bug might be related to #wave-collect - Release 1
Reacted by Christina DobrzynskiThis does not feel like a blocker to me.
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.22 remaining items
@allroundexperts The PR is here.
PR in production. adding a payment date to the Title.
- changed the title
[-][$500] Expense - Request disappears when deleted offline and there are two requests[/-][+][Payment due April 30th] [$500] Expense - Request disappears when deleted offline and there are two requests[/+]on Apr 23, 2024 Whoops! Payouts due:
- Contributor: $500 @nkdengineer (Paid in Upwork - https://www.upwork.com/nx/wm/offer/102145438)
- Contributor+: $500 @allroundexperts (Paid through NewDot)
Upwork job is here.
@allroundexperts @nkdengineer can you please accept the above offers?
Can you let me know about a regression test?
I think a regression test would be helpful here. Here are the test steps:
- Login and Create a workspace so there's no historical Money Requests.
- Find the workspace chat in the LHN
- Create two manual requests.
- Go offline.
- Delete one of the requests.
Verify that the request preview is crossed out when it is deleted offline.
Do we 👍 or 👎 ?
Reacted by Christina Dobrzynski@Christinadobrzyn I accepted the offer 🙏
Reacted by Christina DobrzynskiRegression test here - https://github.com/Expensify/Expensify/issues/393728
@nkdengineer paid you in Upwork based on this payment summary - #39462 (comment)
@allroundexperts are you paid in NewDot or in Upwork (if Upwork can you accept this offer) TY!@Christinadobrzyn It's ND for me!
Reacted by Christina DobrzynskiAwesome! Thanks for confirming!
Payment summary here - #39462 (comment)
This is ready to be closed. Let me know if I missed anything!
$500 approved for @allroundexperts
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by:
Action Performed:
Expected Result:
The request preview will be crossed out when it is deleted offline.
Actual Result:
The request preview is not crossed out when it is deleted offline. The preview is completely gone and user lands in one transaction report view.
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6436037_1712089830389.20240403_042404.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit