Skip to content

[$250] Distance - Expense report turns blank when distance is requested offline and returning online #39461

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: exploratory around https://expensify.testrail.io/index.php?/tests/view/4470385
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat with no unsettled request.
  3. Create a distance request.
  4. Go to one transaction report view.
  5. Go offline.
  6. Create another request.
  7. Go to expense report.
  8. Go online.

Expected Result:

The expense report will not turn blank after the request is generated online.

Actual Result:

The expense report turns blank after the request is generated online.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6436029_1712089068819.20240403_041341.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01931d3dd62fc4be98
  • Upwork Job ID: 1775660164545712128
  • Last Price Increase: 2024-04-04

Activity

  1. kbecciv commented on Apr 2, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  2. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Apr 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. NikkiWines commented on Apr 3, 2024

    @NikkiWines
    Contributor

    this behaviour looks fine to me? @kbecciv can you expand on what expense report turns blank means in this context?

    Edit: Ah, nvm - i see from the video now 👍

  5. NikkiWines commented on Apr 3, 2024

    @NikkiWines
    Contributor

    Weird, this seems to occur regardless of how many expenses are on the report so I don't think it's tied to the recent one-transaction view changes 🤔

    And I can reproduce this error simply by refreshing the page

    Untitled.mov

    Oh but maybe only after experiencing the bug the first time. Also seems to be reproducible on non-distance expenses

  6. NikkiWines commented on Apr 3, 2024

    @NikkiWines
    Contributor

    I'm unable to reproduce this on dev - going to see if there's any sort of reconnect request that could be causing issues 🤔

  7. NikkiWines commented on Apr 3, 2024

    @NikkiWines
    Contributor

    OK, yeah I can reproduce this on staging only with the following steps:

    1. Create an money request on a workspace chat
    2. Create a second money request on a workspace chat
    3. Navigate to to expense report
    4. Go offline
    5. Go back online
    6. Wait a few seconds and see the report page lose all content

    Not sure why this is failing on staging specifically but will continue to investigate tomorrow

  8. jasperhuangg commented on Apr 3, 2024

    @jasperhuangg
    Contributor

    This isn't happening for me on staging. @NikkiWines can you verify if I'm following the reproduction steps correctly?

    repro.mov
  9. NikkiWines commented on Apr 3, 2024

    @NikkiWines
    Contributor

    Hmm, yeah definitely still reproducible for me 😞

    Screen.Recording.2024-04-03.at.11.49.52.mov
  10. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 3, 2024
  11. 31 remaining items

  12. roryabraham commented on Apr 15, 2024

    @roryabraham
    Contributor

    This should be fixed now. requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1713202683220999

  13. melvin-bot commented on Apr 15, 2024

    @melvin-bot

    @NikkiWines, @jliexpensify, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

  14. kavimuru commented on Apr 15, 2024

    @kavimuru

    Still reproduced in mweb

    Record_2024-04-15-21-55-37.mp4
  15. melvin-bot commented on Apr 17, 2024

    @melvin-bot

    @NikkiWines, @jliexpensify, @dukenv0307 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  16. jliexpensify commented on Apr 17, 2024

    @jliexpensify
    Contributor

    @NikkiWines since this is a Polish issue, should we change the priority?

  17. NikkiWines commented on Apr 27, 2024

    @NikkiWines
    Contributor

    I'm unable to reproduce on staging or prod for mweb or web - let's close this out and if this resurfaces we can reopen or handle it in a fresh issue.

    Videos

    Web - Prod

    Screen.Recording.2024-04-26.at.18.11.31.mov

    Web - Staging

    Screen.Recording.2024-04-26.at.18.17.43.mov

    mWeb - Staging

    RPReplay_Final1714180979.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions