[HOLD for payment 2024-04-15] IOU - IOU preview in the main chat does not support mark down, while IOU report supports it

@ishpaul777

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to FAB > Request money > Manual.
Request money from user with no unsettled request and include description with mark down.
Note that the IOU preview in 1:1 DM does not support mark down.
Create a second request with the same user.
Go to IOU report.
Note that the IOU preview of the first request in expense report supports mark down.

Expected Result:

Since IOU preview in IOU report (Step 6) supports mark down, the IOU preview in the main chat should also support mark down.

Actual Result:

The IOU preview in the main chat does not support mark down.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6435885_1712081039309.20240403_015949.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @ishpaul777

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019a357ce26a3a91d5
Upwork Job ID: 1780017603019825152
Last Price Increase: 2024-04-15

@aldo-expensify

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOU preview in the main chat does not support mark down, while IOU report supports it

What is the root cause of that problem?

We don't use renderHTML to render the description in ReportPreview hence it displays as plain-text

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 299 to 305 in 26a2a8f

    
           {shouldShowSubtitle && ( 
        
               <View style={styles.flexRow}> 
        
                   <View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}> 
        
                       <Text style={[styles.textLabelSupporting, styles.textNormal, styles.lh20]}>{previewSubtitle || moneyRequestComment}</Text> 
        
                   </View> 
        
               </View> 
        
           )}

What changes do you think we should make in order to solve the problem?

We should use renderHTML to render the description like we do here:

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Lines 297 to 301 in 26a2a8f

    
           {shouldShowDescription && ( 
        
               <View style={[styles.breakWord, styles.preWrap]}> 
        
                   <RenderHTML html={`<muted-text>${parser.replace(merchantOrDescription)}</muted-text>`} /> 
        
               </View> 
        
           )}

@ishpaul777

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Support markdown for description preview #39466

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

@ishpaul777 requires payment (Needs manual offer from BZ)

@ishpaul777

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
[@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ishpaul777] Determine if we should create a regression test for this bug.
[@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@ishpaul777

Payment Summary

Upwork Job

ROLE: @ishpaul777 paid $500 via Upwork (LINK)

BugZero Checklist (@kadiealexander)

I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Job added to Upwork: https://www.upwork.com/jobs/~019a357ce26a3a91d5

@kadiealexander

hey @kadiealexander The issue was create before the price drop https://expensify.slack.com/archives/C02NK2DQWUX/p1712250884549319, I think provious bounty $500 should be applicable here

Fixed, please accept.

Thank you! Accepted

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-15] IOU - IOU preview in the main chat does not support mark down, while IOU report supports it #39451

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

20 remaining items

Payment Summary

BugZero Checklist (@kadiealexander)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{shouldShowSubtitle && (
	<View style={styles.flexRow}>
	<View style={[styles.flex1, styles.flexRow, styles.alignItemsCenter]}>
	<Text style={[styles.textLabelSupporting, styles.textNormal, styles.lh20]}>{previewSubtitle \|\| moneyRequestComment}</Text>
	</View>
	</View>
	)}

	{shouldShowDescription && (
	<View style={[styles.breakWord, styles.preWrap]}>
	<RenderHTML html={`<muted-text>${parser.replace(merchantOrDescription)}</muted-text>`} />
	</View>
	)}

[HOLD for payment 2024-04-15] IOU - IOU preview in the main chat does not support mark down, while IOU report supports it #39451

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 2, 2024

github-actions commented on Apr 2, 2024

kbecciv commented on Apr 2, 2024

neonbhai commented on Apr 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

20 remaining items

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 15, 2024

Payment Summary

BugZero Checklist (@kadiealexander)

melvin-bot commented on Apr 15, 2024

ishpaul777 commented on Apr 16, 2024

kadiealexander commented on Apr 17, 2024

ishpaul777 commented on Apr 17, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions