Repository navigation
[$250] IOU - Green dot shows up in LHN briefly when requeting money from another user #39447
Description
Activity
Triggered auto assignment to @roryabraham (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@roryabraham FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave-collect - Release 1
reproduced locally on main
reproduced locally on the production branch as well
reproduced in production, demoting
29 remaining items
thanks again for pointing out that issue @nkdengineer - the reproduction steps were very helpful. I ended up fixing the problem in a different way.
@roryabraham There're other regressions with that approach too, please note
needsToBeManuallySubmittedis also used here and hereI'm quite certain that needsToBeManuallySubmitted should only be true for expense reports.
@roryabraham I think the problem here is that the naming of
needsToBeManuallySubmittedis confusing.The use case for that method is:
If this report is an expense report, and it has automatic submit, thenhasOutstandingChildRequestwill always befalse(it's the intention of this condition)That's why
needsToBeManuallySubmittedreturnstruefor personal request, so that thehasOutstandingChildRequestwill not be forced to befalsehere, but will depend on other conditions.We should instead rename to
hasAutomaticSubmission(which is an inverted version ofneedsToBeManuallySubmitted)And we'll use
hasAutomaticSubmission(iouReport)hereI'm still not sure about your RCA though
@roryabraham Did you try keeping the
some logic we had to make admins see expense reports that will be automatically submitted with a green dot(mentioned here)? You'll see the bug in the OP is not fixed right? That's because the RCA is there as I mentioned in my proposalAnd the
needsToBeManuallySubmittedfix doesn't fix the root cause but it's more like a code polish.There're other regressions with that approach too
Can you please provide reproduction steps for these other regressions?
This issue has not been updated in over 15 days. @twisterdotcom, @abdulrahuman5196, @roryabraham eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Are we still waiting on a response to @roryabraham from @nkdengineer here?
Are we still waiting on a response to @roryabraham from @nkdengineer here?
Yes.
@twisterdotcom, @abdulrahuman5196, @roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
Reacted by Ted HarrisIssue is not reproducible
Recording.2174.mp4
That adds up. When I went back to my draft PR, merging main it looked like the core changes had already been made somewhere else. Closing this out
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Green dot will not show up in LHN when requeting money from another user
Actual Result:
Green dot shows up in LHN briefly when requeting money from another user
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6435614_1712065747860.20240402_214557.mp4
Bug6435614_1712065828320.20240402_214912.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit