Repository navigation
[$500] Attachment - 'New message' button appears when deleting attachment #39421
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4468722
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
- Navigate to a report has multiple chat
- Send attachment
- Delete the attachment
- Click on 'New messages' button
Expected Result:
'New messages' button shouldn't appear, and attachment should remain deleted
Actual Result:
'New messages' button appears, and attachment reappear when clicking 'New messages' button
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6435643_1712067883261.Screen_Recording_2024-04-02_at_5.16.43_in_the_afternoon.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~010fcec62910c073e7
- Upwork Job ID: 1775234083431460864
- Last Price Increase: 2024-04-30
- Automatic offers:
- jjcoffee | Reviewer | 0
- c3024 | Contributor | 0
Activity
melvin-bot commentedon Apr 2, 2024
Triggered auto assignment to @deetergp (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 2, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Apr 2, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 2, 2024
@garrettmknight I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 2, 2024
We think this issue might be related to the #vip-vsb.
izarutskaya commentedon Apr 2, 2024
Production
bandicam.2024-04-02.19-07-13-703.mp4
deetergp commentedon Apr 2, 2024
I was able to reproduce this locally. Also navigating away from the chat & back will cause the supposedly deleted attachment to reappear.
71 remaining items
melvin-bot commentedon May 2, 2024
📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
melvin-bot commentedon May 2, 2024
📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
jjcoffee commentedon May 3, 2024
@bernhardoj Thanks for the heads up! Hmm I'm not sure what we'd normally do in this situation. This issue is older so it would normally take precedence, but the other issue is also not a straight dupe of this one...
jjcoffee commentedon May 3, 2024
Just a heads up I'll be OOO 6-13th (I may have some time on the 6th), so this may need to be reassigned depending on what is decided to do here. cc @garrettmknight
kaushiktd commentedon May 6, 2024
@garrettmknight I pulled latest code and this issue appears to be fixed!
melvin-bot commentedon May 7, 2024
@deetergp, @garrettmknight, @jjcoffee, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
deetergp commentedon May 7, 2024
I asked for a re-test here https://expensify.slack.com/archives/C9YU7BX5M/p1715052903386669
kavimuru commentedon May 7, 2024
Issue is fixed.
Screen.Recording.2024-05-07.at.3.42.40.in.the.afternoon.mp4
deetergp commentedon May 7, 2024
@garrettmknight I think we can close this one out.
deetergp commentedon May 8, 2024
Is there anything we need to do before closing this one @garrettmknight?
garrettmknight commentedon May 9, 2024
Just reviewing - doesn't look like we got a PR up or anything so I'm going to just close since this was fixed elsewhere.