Skip to content

[HOLD for payment 2024-04-15] IOU - Combined report appears briefly when navigating to IOU report from transaction thread #39418

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Request money from a user that has no unsettled request.
  3. Create another IOU with the same user.
  4. Go to transaction details of one of the requests.
  5. Add some comments.
  6. Click on the header subtitle to return to IOU report.

Expected Result:

Combined report will not appear since there are more than one requests.

Actual Result:

Combined report appears briefly when navigating to IOU report from transaction thread.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6435642_1712067627162.20240402_221321.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 2, 2024
  2. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. github-actions commented on Apr 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 2, 2024

    @izarutskaya
    Author

    @isabelastisser I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 2, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. izarutskaya commented on Apr 2, 2024

    @izarutskaya
    Author

    Production

    Recording.2332.mp4
  8. 7 remaining items

  9. NikkiWines commented on Apr 2, 2024

    @NikkiWines
    Contributor

    However, I think this can be a polish since it requires someone going through some niche steps to experience and won't be super easily found by users going through a normal flow

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    ReviewingHas a PR in review
    on Apr 2, 2024
  11. NikkiWines commented on Apr 6, 2024

    @NikkiWines
    Contributor

    I'm not seeing this behavior on staging any more - let's close this out and if it pops up again it's a good external issue:

    Screen.Recording.2024-04-05.at.18.33.45.mov
    Screen.Recording.2024-04-05.at.18.35.09.mov
  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 6, 2024
  13. changed the title [-]IOU - Combined report appears briefly when navigating to IOU report from transaction thread[/-] [+][HOLD for payment 2024-04-15] IOU - Combined report appears briefly when navigating to IOU report from transaction thread[/+] on Apr 8, 2024
  14. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

  15. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@NikkiWines] The PR that introduced the bug has been identified. Link to the PR: [HOLD for payment 2024-04-15] IOU - Skeleton IOU preview appears in IOU details page when there is one request #39403
    • [@NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A, it was a bug due to not modifying code, not code that the PR had changed. We missed that flow in the original PR.
    • [@NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@NikkiWines] Determine if we should create a regression test for this bug. N/A
    • [@NikkiWines] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
    • [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions