Repository navigation
[HOLD for payment 2024-04-15] [$500] IOU - Opening IOU receipt leads to not here page #39404
Description
Activity
Triggered auto assignment to @iwiznia (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.We think that this bug might be related to #wave-collect - Release 1
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Opening the money request receipt shows not found page.
What is the root cause of that problem?
The condition to show the not found page is checking whether the report
parentReportIDis not the same as the transactionreportID.
App/src/pages/TransactionReceiptPage.tsx
Line 62 in a1801c8
When this code is made, we can only open the receipt from the transaction thread, so report
parentReportIDwill point to the IOU/expense report, which is the same as transactionreportID.However, after the one transaction report view PR, we are showing the receipt and other money request fields in the IOU report, so the condition is always false because IOU report
parentReportIDpoints to the chat report.What changes do you think we should make in order to solve the problem?
We should check whether the report is a money request report or not. If it's a money request report, we just take the
reportID, otherwise take theparentReportID.const moneyRequestReportID = ReportUtils.isMoneyRequestReport(report) ? report?.reportID : report?.parentReportID; shouldShowNotFoundPage={(moneyRequestReportID ?? '') !== transaction?.reportID}@bernhardoj Can you update your solution to cover Track Expense on selfDM?
Reacted by Ionatan WizniaI don't see the problem with track expense
Just make a track expense with the receipt. And try to open the receipt.
Screen.Recording.2024-04-02.at.23.40.39.mov
Works fine.
Oh. Looks like a BE issue, then. Please continue here.
25 remaining items
Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
For reference, here are some details about the assignees on this issue:
- @bernhardoj requires payment (Needs manual offer from BZ)
- @dukenv0307 requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
- [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@dukenv0307] Determine if we should create a regression test for this bug.
- [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@dukenv0307 and @bernhardoj - please submit a request here:
https://www.upwork.com/jobs/~0170155bec83d697ff
On Monday, I can complete the payment process. Thanks!
Applied!
@dukenv0307 and @bernhardoj - please submit a request here:
@alexpensify Thanks, I've applied to the job too
Payment Summary
- ROLE: @bernhardoj paid $(500) via Upwork (LINK)
- ROLE: @dukenv0307 paid $(500) via Upwork (LINK)
BugZero Checklist (@alexpensify)
- I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1775191991451828224/hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
@dukenv0307 and @bernhardoj - I've sent you offers via Upwork. Please accept and I can complete the payment process.
@alexpensify accepted
Thanks, I was able to complete the payment to @bernhardoj.
@dukenv0307, please accept the offer in Upwork, and I can complete the process. Thanks!
@alexpensify I accepted the UW offer
Perfect, @dukenv0307 has been paid via Upwork. Closing since everyone has been paid via Upwork.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.59-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Receipt opens without issue.
Actual Result:
Opening IOU receipt leads to not here page
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6435480_1712058058413.receipt.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit