Repository navigation
[HOLD #39432][$500] Report - Offline deleted message is not struck through #39307
Description
Activity
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
Proposal
Please re-state the problem that we are trying to solve in this issue.
Message disappears
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
When we delete a message that isn't a thread parent message, the current request is included to handle conflicting request and then we merge the
successDatainto Onyx after we merge the optimistic data of the request here. That is the root cause of the issueApp/src/libs/actions/Report.ts
Line 1321 in 272b05f
App/src/libs/actions/PersistedRequests.ts
Line 40 in 272b05f
What alternative solutions did you explore? (Optional)
We should handle merge the optimistic data of the request after we handle conflicting request
Lines 67 to 69 in 272b05f
To do that we should move this block after we push the request here
Raising this internally because I'm finding contradicting expected behavior.
Okay "greyed out and struck through" is the expected behavior.
- changed the title
[-]Report - Offline deleted message is not struck through[/-][+][$500] Report - Offline deleted message is not struck through[/+]on Apr 3, 2024 Job added to Upwork: https://www.upwork.com/jobs/~0123d5e156c38fe58b
39 remaining items
VSB is on hold. Thinking of moving this to monthly.
Moving to monthly for now.
Going to retest this, it's been quite some time since it was created and tested.
On v9.0.28-2, I am unable to repro. Going offline and deleting a message strikes the message through as expected.
I'm going to close this out as already fixed. Reopen if you disagree.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4467827
Email or phone of affected tester (no customers): natnael.expensify+3@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
Message should be grayed out, and struck through
Actual Result:
Message disappears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6431930_1711737045335.Screen_Recording_2024-03-29_at_9.22.11_at_night.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit