Skip to content

Mark down - Different colour of strikethrough on email depending on bold mark down position #39266

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR around #38152

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat.
  3. Type the following text with mark down (with no space):
  • ~ hello.com ~ *
    ~ * hello.com * ~

Expected Result:

The color of strikethrough in the preview should be consistent

Actual Result:

The color of strikethrough in the preview is different depending on the position of bold mark down.
When the mark down is in this order * ~ hello.com ~ *, the strikethrough is blue
When the mark down is in this order ~ * hello.com * ~, the strikethrough is white

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431683_1711724092674.20240329_225011.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Mar 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. lanitochka17 commented on Mar 29, 2024

    @lanitochka17
    Author

    @flodnv FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Mar 29, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 29, 2024
  6. thienlnam commented on Mar 29, 2024

    @thienlnam
    Contributor

    Not a deploy blocker - added to the main tracking issue

  7. thienlnam commented on Apr 18, 2024

    @thienlnam
    Contributor

    This is pretty low on the priority list of other live markdown issues, so going to put this on a monthly

  8. thienlnam commented on May 29, 2024

    @thienlnam
    Contributor

    Closing, looking at this again I'm not sure there is really a problem here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions