Don't allow upload of large attachments [hold for payment on August 5th]

[rushatgabhane]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

I'm assuming API allows max attachment size of 100 MB. Please correct me if I'm wrong.

Action Performed:

1. Login to E.cash
2. Click add attachment.
3. Select a file larger than 100 MB, and send it.

Expected Result:

Should display a message like "Attachment is larger than 100 MB"
and not allow upload of the attachment.

Actual Result:

The attachment is allowed to upload even though the API doesn't allow uploads larger than 100 MB.
And a forever spinner gets displayed.

Workaround:

N.A.

Platform:

Where is this issue occurring?

Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[rushatgabhane]

Proposal

In components/AttachmentModal

For attachments larger than 100 MB,
show the message "Attachment is larger than 100 MB limit", and disable the send button.

English and Spanish message will be added, and size limit will be set in CONST.js

[MelvinBot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[yuwenmemon]

I'm curious how we picture this error message to show? I don't think we should even render the preview and disable the upload button here. Since a large file would probably be cumbersome to render anyway:

We should probably just flash a separate, solo error message

[yuwenmemon]

Code where this happens:

App/src/components/AttachmentPicker/index.js

Lines 19 to 28 in beb40ee

	onChange={(e) => {
	const file = e.target.files[0];
	if (file) {
	file.uri = URL.createObjectURL(file);
	this.onPicked(file);
	}
	// Cleanup after selecting a file to start from a fresh state
	this.fileInput.value = null;

[yuwenmemon]

Spanish translation: El documento adjunto supera el límite de 100 MB

[quinthar]

Yes, if the image is too big, I don't think we'd show a preview (especially because odds are it's a format that won't have a preview).

…

On Mon, Jul 26, 2021 at 2:28 PM Yuwen Memon ***@***.***> wrote: I'm curious how we picture this error message to show? I don't think we should even render the preview and disable the upload button here. Since a large file would probably be cumbersome to render anyway: [image: Screen Shot 2021-07-26 at 2 27 35 PM] <https://user-images.githubusercontent.com/4741899/127061563-dd141818-e7c9-44b7-a4f7-aa87ae1e403a.png> We should probably just flash a separate, solo error message — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3926 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUTPXAUYSAQ456TA56DTZXHRLANCNFSM5AAFC6YQ> .