Repository navigation
[$250] Web - Chat - Composer is expanded briefly when returning to chat after creating new workspace #39252
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to Profile > Workspaces
- Create a new workspace
- Click back button on the top left
- Click Chat icon on the bottom left
Expected Result:
The composer will not appear expanded when returning to chat
Actual Result:
The composer appears expanded briefly when returning to chat after creating a new workspace
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6431596_1711719926703.composer_expand.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0187883d3354706f5f
- Upwork Job ID: 1776300112459137024
- Last Price Increase: 2024-04-12
Activity
melvin-bot commentedon Mar 29, 2024
Triggered auto assignment to @thienlnam (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Mar 29, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
ZhenjaHorbach commentedon Mar 29, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Chat - Composer is expanded briefly when returning to chat after creating new workspace
What is the root cause of that problem?
Problem related with the fact that when we get isComposerFullSize from onyx it equals
{}App/src/pages/home/ReportScreen.tsx
Lines 693 to 696 in 540c5dd
And then we get true from {}
App/src/pages/home/ReportScreen.tsx
Line 649 in 540c5dd
What changes do you think we should make in order to solve the problem?
So maybe the problem is related to onyx
But as an alternative we can add a check for object using selector and return false in this case
App/src/pages/home/ReportScreen.tsx
Lines 693 to 696 in 540c5dd
What alternative solutions did you explore? (Optional)
NA
thienlnam commentedon Mar 29, 2024
Not a blocker - added to the main tracking issue
[-]Web - Chat - Composer is expanded briefly when returning to chat after creating new workspace[/-][+][$250] Web - Chat - Composer is expanded briefly when returning to chat after creating new workspace[/+]melvin-bot commentedon Apr 5, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0187883d3354706f5f
19 remaining items
melvin-bot commentedon Apr 11, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.thienlnam commentedon Apr 11, 2024
So to double check, this is no longer reproducible?
melvin-bot commentedon Apr 12, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
melvin-bot commentedon Apr 12, 2024
@mananjadhav @anmurali @thienlnam this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
anmurali commentedon Apr 17, 2024
Yea, I cannot reproduce on staging or prod. Closing.
MelvinBot commentedon Apr 17, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989