Skip to content

[HOLD for payment 2024-04-15] Mark down - App crashes when entering an emoji inside three backticks code block #39236

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any chat.
  3. Enter three backticks code block.
  4. Enter an emoji inside the code block.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

bandicam.2024-03-29.11-04-10-247.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Mar 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. kbecciv commented on Mar 29, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb

  4. flodnv commented on Mar 29, 2024

    @flodnv
    Contributor

    @Skalakid @thienlnam I suspect this is caused by #38152, can you take a look?

    Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1711714839163149

  5. BartoszGrajdek commented on Mar 29, 2024

    @BartoszGrajdek
    Contributor

    Fix in review 👀

  6. added and removed on Mar 29, 2024
  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 8, 2024
  8. changed the title [-] Mark down - App crashes when entering an emoji inside three backticks code block[/-] [+][HOLD for payment 2024-04-15] Mark down - App crashes when entering an emoji inside three backticks code block[/+] on Apr 8, 2024
  9. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions