Repository navigation
[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] [TS Migration] Define a concise way to access or default to an inexistent record #39125
Description
Follow up issue for TS migration project. Coming from this spreadsheet
Define a concise way to access or default to an inexistent record (0, -1, etc)
Any more details for this one cc @blazejkustra @fabioh8010
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0127e590dfa2accb42
- Upwork Job ID: 1780548153949810688
- Last Price Increase: 2024-04-24
- Automatic offers:
- jjcoffee | Reviewer | 0
- godofoutcasts94 | Contributor | 0
Activity
[-][TS Migration] Define a concise way to access or default to an inexistent record[/-][+][HOLD TS migration completion] [TS Migration] Define a concise way to access or default to an inexistent record[/+]fabioh8010 commentedon Apr 16, 2024
Problem
Currently we have been defaulting nullable entity IDs to either
0or-1when it doesn’t exist as we can see here and here (and many other files throughout the project). The lack of conciseness when defaulting such IDs leads to confusion between developers and increased chance of bugs.Solution
Standartise the default values of all Onyx entity IDs. Personally I think we should default all nullable entity IDs to
-1as it is a negative ID and theoretically we would never have a negative one in the DB (@mountiny makes sense to you?):src/types/onyx/, look for properties that ends withID?: ..., e.g.managerID?: number;,parentReportID?: string;,iouReportID?: string;inside Report.ts0or-1, change it to-1.TS_STYLE.mdto include this advice of using-1to default these kind of ID properties.[-][HOLD TS migration completion] [TS Migration] Define a concise way to access or default to an inexistent record[/-][+][TS Migration] Define a concise way to access or default to an inexistent record[/+]mountiny commentedon Apr 16, 2024
@fabioh8010 this makes sense to me, but I think we need to bring this up to slack for broader agreement, can you post the proposal to open source channel before proceeding?
fabioh8010 commentedon Apr 17, 2024
@mountiny Sure, I can post! But could you make this issue External? It was marked as External initially.
84 remaining items
melvin-bot commentedon Jun 17, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-06-24] [$250] [TS Migration] Define a concise way to access or default to an inexistent record[/-][+][HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] [TS Migration] Define a concise way to access or default to an inexistent record[/+]melvin-bot commentedon Jun 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-06-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 21, 2024
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
johncschuster commentedon Jun 24, 2024
Discussing in Slack to make sure I'm understanding the correct payment date
johncschuster commentedon Jun 25, 2024
@jjcoffee do we need a regression test for this? If so, can you propose the steps?
johncschuster commentedon Jun 25, 2024
Payment Summary:
Contributor: @kubabutkiewicz - does not require payment
Contributor+: @jjcoffee - $250 - paid via Upwork - PAID
jjcoffee commentedon Jun 26, 2024
@johncschuster No I don't think so, since this is an app-wide change.
johncschuster commentedon Jun 26, 2024
Awesome. Thank you!