Repository navigation
[HOLD for payment 2024-04-15] HIGH: [Reliability] Create a 1:1:1 GetMissingOnyxMessagesForPushNotification API command #38954
Description
Problem:
Every time you get a push message, we send ReconnectApp, which sometimes does GetMissingOnyxMessages behind the scenes. This breaks 1:1:1 because every API call should generate at most one Auth call, and in this case it generates multiple.
Additionally, sometime we also send OptInToPushNotifications. This is violating our 1:1:1 principle, as every user action (in this case, receiving a push message) should generate a single API call -- and this is sometimes generating two.
Finally, it seems like we send this even if the incoming push notification shows no "gap" with the previous update.
Solution:
Fix this to follow 1:1:1 by:
- Create a new
ReceivedPushNotificationWithUpdateGapAPI command that accepts afromUpdateIDandtoUpdateIDrange - When receiving a new push notification, check to see if the
lastUpdateIDof the notification matches thelastUpdateIDof the client -- and only sendReceivedPushNotificationWithUpdateGapif there is a gap detected
Activity
melvin-bot commentedon Mar 25, 2024
Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.
iwiznia commentedon Mar 25, 2024
This is not correct.
Huh? I don't get this at all, are you saying we are breaking the
do not make 2 api calls from app for a single user actionor thedo not make 2 auth calls from a single php request?But also, I don't think neither of those is happening in this flow.
arosiclair commentedon Mar 25, 2024
ReconnectApp should be 1:1:1. It fetches the gap of onyx updates with
GetOnyxUpdatesin Auth. If it fails to do that, it does a "full" reconnect. The "full reconnect" includes many Auth calls, but they are all reads so it should not violate 1:1:1.We should stop doing this 👍
This part is intentional. We're attempting to fetch additional updates to keep your app up to date. This does mean that receiving a push notification in the background may generate two ReconnectApp calls:
lastUpdateIDWe could combine these though it'll be a little tricky.
arosiclair commentedon Mar 26, 2024
Posted a PR for
OptInToPushNotifications^4 remaining items
arosiclair commentedon Apr 3, 2024
After some discussion we decided not to add a new command since it would be identical to
GetMissingOnyxMessages. So all we need left is the App PR to remove the extraReconnectAppcall.However, one thing I'm noticing on Android is that
GetMissingOnyxMessagesis NOT being called when the app wakes in the background. What I'm seeing is:ONYX_UPDATES_FROM_SERVERgets set in Onyx to fill the gapONYX_UPDATES_FROM_SERVERdoes NOT run and thusGetMissingOnyxMessagesis not called.The next time the app is opened, the callback finally runs and fills the gap. So it seems there are issues running Onyx callbacks in the background process. I confirmed this by moving that code out of the callback and just running it synchronously and it worked.
This is a separate problem so I'll make a follow up issue to address it, but in the meantime, we should probably expect a bit of regression for background refresh.
Follow up here: #39544
arosiclair commentedon Apr 4, 2024
This was CP'd to staging and should be on production soon
[-]HIGH: [Reliability] Create a 1:1:1 `GetMissingOnyxMessagesForPushNotification` API command[/-][+][HOLD for payment 2024-04-15] HIGH: [Reliability] Create a 1:1:1 `GetMissingOnyxMessagesForPushNotification` API command[/+]melvin-bot commentedon Apr 8, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
arosiclair commentedon Apr 8, 2024
All done!