[HOLD for payment 2024-04-15] [$125] Change the order of items in the global create #38950

Activity

1. thienlnam

   added

   Engineering

   DailyKSv2KSv2

   on Mar 25, 2024
2. thienlnam

   self-assigned this

   on Mar 25, 2024
3. ShridharGoel commented on Mar 25, 2024

   

   ShridharGoel

   on Mar 25, 2024

   Last edited by ShridharGoel

   Contributor

   More actions

   Proposal

   Please re-state the problem that we are trying to solve in this issue.

   Change the order of items in the global create.

   What is the root cause of that problem?

   New change.

   This is the order currently:
   

   App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

   Lines 160 to 233 in a5189c4

   	menuItems={[
   	{
   	icon: Expensicons.ChatBubble,
   	text: translate('sidebarScreen.fabNewChat'),
   	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.NEW)),
   	},
   	{
   	icon: Expensicons.MoneyCircle,
   	text: translate('iou.requestMoney'),
   	onSelected: () =>
   	interceptAnonymousUser(() =>
   	IOU.startMoneyRequest(
   	CONST.IOU.TYPE.REQUEST,
   	// When starting to create a money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
   	// for all of the routes in the creation flow.
   	ReportUtils.generateReportID(),
   	),
   	),
   	},
   	{
   	icon: Expensicons.Send,
   	text: translate('iou.sendMoney'),
   	onSelected: () =>
   	interceptAnonymousUser(() =>
   	IOU.startMoneyRequest(
   	CONST.IOU.TYPE.SEND,
   	// When starting to create a send money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
   	// for all of the routes in the creation flow.
   	ReportUtils.generateReportID(),
   	),
   	),
   	},
   	...(canUseTrackExpense
   	? [
   	{
   	icon: Expensicons.DocumentPlus,
   	text: translate('iou.trackExpense'),
   	onSelected: () =>
   	interceptAnonymousUser(() =>
   	IOU.startMoneyRequest(
   	CONST.IOU.TYPE.TRACK_EXPENSE,
   	// When starting to create a track expense from the global FAB, we need to retrieve selfDM reportID.
   	// If it doesn't exist, we generate a random optimistic reportID and use it for all of the routes in the creation flow.
   	ReportUtils.findSelfDMReportID() || ReportUtils.generateReportID(),
   	),
   	),
   	},
   	]
   	: []),
   	{
   	icon: Expensicons.Task,
   	text: translate('newTaskPage.assignTask'),
   	onSelected: () => interceptAnonymousUser(() => Task.clearOutTaskInfoAndNavigate()),
   	},
   	{
   	icon: Expensicons.Heart,
   	text: translate('sidebarScreen.saveTheWorld'),
   	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TEACHERS_UNITE)),
   	},
   	...(!props.isLoading && !Policy.hasActiveChatEnabledPolicies(props.allPolicies)
   	? [
   	{
   	displayInDefaultIconColor: true,
   	contentFit: 'contain',
   	icon: Expensicons.NewWorkspace,
   	iconWidth: 46,
   	iconHeight: 40,
   	text: translate('workspace.new.newWorkspace'),
   	description: translate('workspace.new.getTheExpensifyCardAndMore'),
   	onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
   	},
   	]
   	: []),
   	]}

   What changes do you think we should make in order to solve the problem?

   We can change it to this:

   menuItems={[
     {
         icon: Expensicons.ChatBubble,
         text: translate('sidebarScreen.fabNewChat'),
         onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.NEW)),
     },
     ...(canUseTrackExpense
         ? [
             {
                 icon: Expensicons.DocumentPlus,
                 text: translate('iou.trackExpense'),
                 onSelected: () =>
                     interceptAnonymousUser(() =>
                         IOU.startMoneyRequest(
                             CONST.IOU.TYPE.TRACK_EXPENSE,
                             // When starting to create a track expense from the global FAB, we need to retrieve selfDM reportID.
                             // If it doesn't exist, we generate a random optimistic reportID and use it for all of the routes in the creation flow.
                             ReportUtils.findSelfDMReportID() || ReportUtils.generateReportID(),
                         ),
                     ),
             },
         ]
         : []),
     {
         icon: Expensicons.MoneyCircle,
         text: translate('iou.requestMoney'),
         onSelected: () =>
             interceptAnonymousUser(() =>
                 IOU.startMoneyRequest(
                     CONST.IOU.TYPE.REQUEST,
                     // When starting to create a money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
                     // for all of the routes in the creation flow.
                     ReportUtils.generateReportID(),
                 ),
             ),
     },
     {
         icon: Expensicons.Send,
         text: translate('iou.sendMoney'),
         onSelected: () =>
             interceptAnonymousUser(() =>
                 IOU.startMoneyRequest(
                     CONST.IOU.TYPE.SEND,
                     // When starting to create a send money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
                     // for all of the routes in the creation flow.
                     ReportUtils.generateReportID(),
                 ),
             ),
     },
     {
         icon: Expensicons.Task,
         text: translate('newTaskPage.assignTask'),
         onSelected: () => interceptAnonymousUser(() => Task.clearOutTaskInfoAndNavigate()),
     },
     {
         icon: Expensicons.Heart,
         text: translate('sidebarScreen.saveTheWorld'),
         onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TEACHERS_UNITE)),
     },
     ...(!props.isLoading && !Policy.hasActiveChatEnabledPolicies(props.allPolicies)
         ? [
               {
                   displayInDefaultIconColor: true,
                   contentFit: 'contain',
                   icon: Expensicons.NewWorkspace,
                   iconWidth: 46,
                   iconHeight: 40,
                   text: translate('workspace.new.newWorkspace'),
                   description: translate('workspace.new.getTheExpensifyCardAndMore'),
                   onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
               },
           ]
         : []),
   ]}
   
4. habasefa commented on Mar 25, 2024

   

   habasefa

   on Mar 25, 2024

   More actions

   Proposal

   Please re-state the problem that we are trying to solve in this issue.

   Changing the the order to the new order of items in the global create

   What is the root cause of that problem?

   New order of items in the global create

   The current ordering is like this:
   

   App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

   Lines 160 to 233 in a5189c4

   	menuItems={[
   	{
   	icon: Expensicons.ChatBubble,
   	text: translate('sidebarScreen.fabNewChat'),
   	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.NEW)),
   	},
   	{
   	icon: Expensicons.MoneyCircle,
   	text: translate('iou.requestMoney'),
   	onSelected: () =>
   	interceptAnonymousUser(() =>
   	IOU.startMoneyRequest(
   	CONST.IOU.TYPE.REQUEST,
   	// When starting to create a money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
   	// for all of the routes in the creation flow.
   	ReportUtils.generateReportID(),
   	),
   	),
   	},
   	{
   	icon: Expensicons.Send,
   	text: translate('iou.sendMoney'),
   	onSelected: () =>
   	interceptAnonymousUser(() =>
   	IOU.startMoneyRequest(
   	CONST.IOU.TYPE.SEND,
   	// When starting to create a send money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
   	// for all of the routes in the creation flow.
   	ReportUtils.generateReportID(),
   	),
   	),
   	},
   	...(canUseTrackExpense
   	? [
   	{
   	icon: Expensicons.DocumentPlus,
   	text: translate('iou.trackExpense'),
   	onSelected: () =>
   	interceptAnonymousUser(() =>
   	IOU.startMoneyRequest(
   	CONST.IOU.TYPE.TRACK_EXPENSE,
   	// When starting to create a track expense from the global FAB, we need to retrieve selfDM reportID.
   	// If it doesn't exist, we generate a random optimistic reportID and use it for all of the routes in the creation flow.
   	ReportUtils.findSelfDMReportID() || ReportUtils.generateReportID(),
   	),
   	),
   	},
   	]
   	: []),
   	{
   	icon: Expensicons.Task,
   	text: translate('newTaskPage.assignTask'),
   	onSelected: () => interceptAnonymousUser(() => Task.clearOutTaskInfoAndNavigate()),
   	},
   	{
   	icon: Expensicons.Heart,
   	text: translate('sidebarScreen.saveTheWorld'),
   	onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.TEACHERS_UNITE)),
   	},
   	...(!props.isLoading && !Policy.hasActiveChatEnabledPolicies(props.allPolicies)
   	? [
   	{
   	displayInDefaultIconColor: true,
   	contentFit: 'contain',
   	icon: Expensicons.NewWorkspace,
   	iconWidth: 46,
   	iconHeight: 40,
   	text: translate('workspace.new.newWorkspace'),
   	description: translate('workspace.new.getTheExpensifyCardAndMore'),
   	onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
   	},
   	]
   	: []),
   	]}

   What changes do you think we should make in order to solve the problem?

   We have to change the ordering on FloatingActionButtonAndPopover.js (If Save the world is intentionally left from the list)
   

   menuItems={[

   {
   icon: Expensicons.ChatBubble,
   text: translate('sidebarScreen.fabNewChat'),
   onSelected: () => interceptAnonymousUser(() => Navigation.navigate(ROUTES.NEW)),
   },
   ...(canUseTrackExpense
   ? [
   {
   icon: Expensicons.DocumentPlus,
   text: translate('iou.trackExpense'),
   onSelected: () =>
   interceptAnonymousUser(() =>
   IOU.startMoneyRequest(
   CONST.IOU.TYPE.TRACK_EXPENSE,
   // When starting to create a track expense from the global FAB, we need to retrieve selfDM reportID.
   // If it doesn't exist, we generate a random optimistic reportID and use it for all of the routes in the creation flow.
   ReportUtils.findSelfDMReportID() || ReportUtils.generateReportID(),
   ),
   ),
   },
   ]
   : []),
   {
   icon: Expensicons.MoneyCircle,
   text: translate('iou.requestMoney'),
   onSelected: () =>
   interceptAnonymousUser(() =>
   IOU.startMoneyRequest(
   CONST.IOU.TYPE.REQUEST,
   // When starting to create a money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
   // for all of the routes in the creation flow.
   ReportUtils.generateReportID(),
   ),
   ),
   },
   {
   icon: Expensicons.Send,
   text: translate('iou.sendMoney'),
   onSelected: () =>
   interceptAnonymousUser(() =>
   IOU.startMoneyRequest(
   CONST.IOU.TYPE.SEND,
   // When starting to create a send money request from the global FAB, there is not an existing report yet. A random optimistic reportID is generated and used
   // for all of the routes in the creation flow.
   ReportUtils.generateReportID(),
   ),
   ),
   },
   {
   icon: Expensicons.Task,
   text: translate('newTaskPage.assignTask'),
   onSelected: () => interceptAnonymousUser(() => Task.clearOutTaskInfoAndNavigate()),
   },
   ...(!props.isLoading && !Policy.hasActiveChatEnabledPolicies(props.allPolicies)
   ? [
   {
   displayInDefaultIconColor: true,
   contentFit: 'contain',
   icon: Expensicons.NewWorkspace,
   iconWidth: 46,
   iconHeight: 40,
   text: translate('workspace.new.newWorkspace'),
   description: translate('workspace.new.getTheExpensifyCardAndMore'),
   onSelected: () => interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt()),
   },
   ]
   : []),
   ]}

   What alternative solutions did you explore? (Optional)
5. ShridharGoel commented on Mar 27, 2024

   

   ShridharGoel

   on Mar 27, 2024

   Contributor

   More actions

   @thienlnam Can this be made external? We can keep the bounty minimal since the change is small.
6. thienlnam commented on Mar 27, 2024

   

   thienlnam

   on Mar 27, 2024

   ContributorAuthor

   More actions

   Yup, was confirming this change but going to make external now
7. thienlnam

   added

   ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor

   on Mar 27, 2024
8. melvin-bot

   changed the title [-]Change the order of items in the global create[/-] [+][$500] Change the order of items in the global create[/+] on Mar 27, 2024
9. melvin-bot commented on Mar 27, 2024

   

   melvin-botbot

   on Mar 27, 2024 – with Melvin Bot

   More actions

   Job added to Upwork: https://www.upwork.com/jobs/~01935b1cfdaa846be8
10. melvin-bot

    added

    Help WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

    on Mar 27, 2024
11. melvin-bot

    assigned

    akinwale

    on Mar 27, 2024
12. melvin-bot commented on Mar 27, 2024

    

    melvin-botbot

    on Mar 27, 2024 – with Melvin Bot

    More actions

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)
13. thienlnam

    changed the title [-][$500] Change the order of items in the global create[/-] [+][$125] Change the order of items in the global create[/+] on Mar 27, 2024
14. melvin-bot commented on Mar 27, 2024

    

    melvin-botbot

    on Mar 27, 2024 – with Melvin Bot

    More actions

    Upwork job price has been updated to $125
15. 10 remaining items

    Load more
16. melvin-bot

    added

    WeeklyKSv2KSv2

    on Mar 28, 2024
17. melvin-bot

    added

    WeeklyKSv2KSv2

    Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to production

    and removed

    WeeklyKSv2KSv2

    on Apr 8, 2024
18. melvin-bot

    changed the title [-][$125] Change the order of items in the global create[/-] [+][HOLD for payment 2024-04-15] [$125] Change the order of items in the global create[/+] on Apr 8, 2024
19. melvin-bot

    removed

    ReviewingHas a PR in reviewHas a PR in review

    on Apr 8, 2024
20. melvin-bot commented on Apr 8, 2024

    

    melvin-botbot

    on Apr 8, 2024 – with Melvin Bot

    More actions

    Reviewing label has been removed, please complete the "BugZero Checklist".
21. melvin-bot commented on Apr 8, 2024

    

    melvin-botbot

    on Apr 8, 2024 – with Melvin Bot

    More actions

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    • Change the order of items in global create menu #39204

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

    • @akinwale requires payment automatic offer (Reviewer)
    • @ShridharGoel requires payment automatic offer (Contributor)
22. melvin-bot

    added

    DailyKSv2KSv2

    and removed

    WeeklyKSv2KSv2

    on Apr 14, 2024
23. melvin-bot

    assigned

    isabelastisser

    on Apr 15, 2024
24. melvin-bot commented on Apr 15, 2024

    

    melvin-botbot

    on Apr 15, 2024 – with Melvin Bot

    More actions

    Issue is ready for payment but no BZ is assigned. @isabelastisser you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
25. isabelastisser commented on Apr 15, 2024

    

    isabelastisser

    on Apr 15, 2024

    Contributor

    More actions

    All set in Upwork. Closing!
26. isabelastisser

    closed this as completedon Apr 15, 2024
27. ShridharGoel commented on Apr 15, 2024

    

    ShridharGoel

    on Apr 15, 2024

    Contributor

    More actions

    @isabelastisser I've accepted the offer.

    👍React with 👍1Reacted by isabelastisser