[HOLD for payment 2024-04-05] [$500] Skeleton is displayed when navigating to a transaction thread created offline

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.55-2
Reproducible in staging?: no
Reproducible in production?: no
Issue reported by: @youssef-lr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711054985550349

Action Performed:

1. Create a chat with someone online
2. Request money from them then navigate to the money report (click on the preview).
3. Go offline and request again from the money report.
4. Try to navigate to the transaction thread of the request created offline.

Expected Result:

it should display the transaction thread where we can edit the fields

Actual Result:

It shows an infinite skeleton loader

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2024-03-21.at.20.56.26.1.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01694ea7e3c07bf01d
• Upwork Job ID: 1771247582016843776
• Last Price Increase: 2024-03-22
• Automatic offers:
• situchan | Reviewer | 0

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[roryabraham]

this is reproducible on main but not staging, so will be a deploy blocker once we ship the current checklist. For that reason, I'm not marking it as external, but going to ask @perunt to investigate a fix, as there seems to be consensus in slack that this is a regression from #30269

[situchan]

Happy to review this if C+ is needed

[roryabraham]

I found that the optimistic IOU action has a childReportID field, that does point to an optimistic chat report. That optimistic chat report has a single optimistic CREATED action So that's all as expected

[roryabraham]

shouldShowSkeleton is getting stuck as true here

isLoadingInitialReportActions appears to be the problem, but interestingly it's wrong in the reportMetadata as well

[roryabraham]

ok, it appears that the reportMetadata for the report in question is somehow getting deleted, and since isLoadingInitialReportActions defaults to true in ReportScreen, it's getting stuck there

edit: It appears the debug util Onyx.log just randomly stopped working for me...
edit 2: nope, it works fine I just had a filter on 🤦

[roryabraham]

Did git checkout b3068864afeaedd448cb59107629fc5cb67fe009~1 and verified this is not reproducible pre-comment-linking

[roryabraham]

Interestingly isLoadingInitialReportActions was getting stuck on true before, it just didn't matter because we weren't relying on it to be correct: