Skip to content

[HOLD for payment 2024-04-05] [Simplified Collect][Taxes] Android - Workspace - Tax name field isn't auto focused the keyboard isn't visible #38572

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.54.0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #37967
Issue reported by: Applause - Internal team

Action Performed:

Precondition: With a new expensifail account in OD, create a Collect workspace with workspace chat enabled.

  1. In ND, log in with the same account
  2. Navigate to Workspace settings - More features
  3. Enable Taxes
  4. Navigate to Workspace settings - Taxes
  5. Tap on the "+ Add rate" button
  6. Tap on the "Name" field

Expected Result:

The keyboard should be visible.

Actual Result:

Tax name field isn't auto focused, the keyboard isn't visible, only the cursor is shown. The keyboard appears if you tap inside the field.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418905_1710834758344.az_recorder_20240319_084531.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cb504f048b994348
  • Upwork Job ID: 1770073117296906240
  • Last Price Increase: 2024-03-19
  • Automatic offers:
    • alitoshmatov | Reviewer | 0

Activity

  1. github-actions commented on Mar 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Mar 19, 2024

    @melvin-bot

    Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. kbecciv commented on Mar 19, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. Krishna2323 commented on Mar 19, 2024

    @Krishna2323
    Contributor
  5. nkdengineer commented on Mar 19, 2024

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Tax name field isn't auto focused, the keyboard isn't visible, only the cursor is shown. The keyboard appears if you tap inside the field.

    What is the root cause of that problem?

    We pass autoFocus props into tax name TextInput that makes the cursor appears but the keyboard doesn't appear

    What changes do you think we should make in order to solve the problem?

    We should use useAutoFocusInput hook in TextSelectModal and pass the ref as inputCallbackRef here instead of passing autoFocus

    What alternative solutions did you explore? (Optional)

    NA

  6. kosmydel commented on Mar 19, 2024

    @kosmydel
    Contributor

    I think it's a duplicate of this issue: #38497

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 19, 2024
  8. changed the title [-]Android - Workspace - Tax name field isn't auto focused the keyboard isn't visible[/-] [+][$500] Android - Workspace - Tax name field isn't auto focused the keyboard isn't visible[/+] on Mar 19, 2024
  9. melvin-bot commented on Mar 19, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 19, 2024
  11. 29 remaining items

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 25, 2024
  13. changed the title [-][Simplified Collect][Taxes] Android - Workspace - Tax name field isn't auto focused the keyboard isn't visible[/-] [+][HOLD for payment 2024-04-05] [Simplified Collect][Taxes] Android - Workspace - Tax name field isn't auto focused the keyboard isn't visible[/+] on Mar 29, 2024
  14. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-05. 🎊

    For reference, here are some details about the assignees on this issue:

  16. alitoshmatov commented on Apr 1, 2024

    @alitoshmatov
    Contributor

    No payment needed for me as C+ reviewer

  17. melvin-bot commented on Apr 5, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @bfitzexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  18. luacmartins commented on Apr 5, 2024

    @luacmartins
    Contributor

    No payment needed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions