Repository navigation
[HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value #38502
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @francoisl (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.We think that this bug might be related to #wave-control
@francoisl The app crashes when adding the distance rate, do we need to create a separate GH or the same root cause?
RPReplay_Final1710786838.MP4
@abzokhattab , looks like the same RCA is applicable here too as you mentioned over that issue
I can repro on iOS, this seems to come from #37967.
The app crashes when adding the distance rate, do we need to create a separate GH or the same root cause
Not sure yet but it might be a different cause, the PR I linked to is specific to tax rates. Maybe it's safer to open a separate issue for now.
This was introduced #37967. This is NAB since this feature is only available on Collect policies in NewDot and users don't have access to that yet. I think we can address that as a follow up to the other tax PRs. cc @kosmydel @filip-solecki
Reacted by Francois Laithier- added and removed
on Mar 18, 2024 15 remaining items
- changed the title
[-][Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/-][+][HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/+]on Mar 19, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-26. 🎊
- changed the title
[-][HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/-][+][HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/+]on Mar 22, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-29. 🎊
- changed the title
[-][HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/-][+][HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/+]on Mar 29, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-05. 🎊
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.54-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:
Expected Result:
Able to add tax value
Actual Result:
App crashes
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6418175_1710785068726.RPReplay_Final1710784552.1.mp4
View all open jobs on GitHub