Skip to content

[HOLD for payment 2024-03-26] [HIGH] [$500] [Mentions] Cannot confirm mention via clicking or hitting the enter key #38358

Closed
Closed
[HOLD for payment 2024-03-26] [HIGH] [$500] [Mentions] Cannot confirm mention via clicking or hitting the enter key#38358
Assignees
allroundexpertsmountinybfitzexpensifygetusha
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Description

@dylanexpensify
dylanexpensify
opened on Mar 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v1.4.51-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dylanexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1710448753252709

Action Performed:

  1. Head to any room
  2. Thread any comment in the room
  3. Mention any user in the thread who hasn't commented in it

Expected Result:

The mention is selected, auto-filled, and the hover menu disappears

Actual Result:

The mention flickers and doesn't complete. On prod, it updates the handle, but still flickers and doesn't complete.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-03-14.at.8.35.15.PM.mov
Screen.Recording.2024-03-14.at.8.47.14.PM.mov
Screen.Recording.2024-03-14.at.8.42.43.PM.mov
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01072b12ec0438630b
  • Upwork Job ID: 1768384067744870400
  • Last Price Increase: 2024-03-14
  • Automatic offers:
    • getusha | Contributor | 0

Activity

  1. dylanexpensify
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 14, 2024
  2. melvin-bot
    assigned
    bfitzexpensify
    on Mar 14, 2024

  3. melvin-bot commented on Mar 14, 2024

    @melvin-bot
    melvin-botBot
    on Mar 14, 2024 – with Melvin Bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. mountiny
    added this to [#whatsnext] #vip-vsbon Mar 14, 2024
  5. mountiny
    moved this to CRITICAL in [#whatsnext] #vip-vsbon Mar 14, 2024
  6. mountiny
    assigned
    allroundexperts
    ,
    mountiny
    and
    bfitzexpensify
    and unassigned
    bfitzexpensify
    on Mar 14, 2024
  7. mountiny
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 14, 2024
  8. melvin-bot
    changed the title [-]Cannot confirm mention via clicking or hitting the enter key[/-] [+][$500] Cannot confirm mention via clicking or hitting the enter key[/+] on Mar 14, 2024

  9. melvin-bot commented on Mar 14, 2024

    @melvin-bot
    melvin-botBot
    on Mar 14, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01072b12ec0438630b

  10. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 14, 2024

  11. melvin-bot commented on Mar 14, 2024

    @melvin-bot
    melvin-botBot
    on Mar 14, 2024 – with Melvin Bot

    Current assignee @allroundexperts is eligible for the External assigner, not assigning anyone new.

  12. 17 remaining items

  13. melvin-bot
    changed the title [-][HIGH] [$500] Cannot confirm mention via clicking or hitting the enter key[/-] [+][HOLD for payment 2024-03-26] [HIGH] [$500] Cannot confirm mention via clicking or hitting the enter key[/+] on Mar 19, 2024
  14. melvin-bot
    removed
    ReviewingHas a PR in review
    on Mar 19, 2024

  15. melvin-bot commented on Mar 19, 2024

    @melvin-bot
    melvin-botBot
    on Mar 19, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Mar 19, 2024

    @melvin-bot
    melvin-botBot
    on Mar 19, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-26. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Mar 19, 2024

    @melvin-bot
    melvin-botBot
    on Mar 19, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@allroundexperts / @getusha] The PR that introduced the bug has been identified. Link to the PR:
    • [@allroundexperts / @getusha] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@allroundexperts / @getusha] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@allroundexperts / @getusha] Determine if we should create a regression test for this bug.
    • [@allroundexperts / @getusha] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. quinthar
    changed the title [-][HOLD for payment 2024-03-26] [HIGH] [$500] Cannot confirm mention via clicking or hitting the enter key[/-] [+][HOLD for payment 2024-03-26] [HIGH] [$500] [Mentions] Cannot confirm mention via clicking or hitting the enter key[/+] on Mar 25, 2024
  19. melvin-bot
    added
    Overdue
    on Apr 1, 2024

  20. getusha commented on Apr 2, 2024

    @getusha
    getusha
    on Apr 2, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Proposal

    1. Open any room/dm
    2. Make sure you're signed in with private domain email not @gmail.com or any other public provider.
    3. Open a thread from any message in the chat
    4. Mention any user (has to be from same private domain)
    5. Highlight the result and hit enter
    6. Verify that the mention is inserted and the popup is closed
    7. Repeat step 4 and press/tap on the result
    8. Verify that the mention is inserted and the popup is closed

    Do we agree 👍 or 👎

  21. melvin-bot
    removed
    Overdue
    on Apr 2, 2024
  22. melvin-bot
    added
    Overdue
    on Apr 10, 2024

  23. bfitzexpensify commented on Apr 16, 2024

    @bfitzexpensify
    bfitzexpensify
    on Apr 16, 2024
    Contributor

    Payment summary:

    @getusha to be paid $500 for contributor work - paid via Upwork ✅
    @allroundexperts to be paid $500 for C+ work - to be made via manual request

    Regression steps proposed in https://github.com/Expensify/Expensify/issues/388157.

    We're all done here, thanks everyone.

  24. bfitzexpensify
    closed this as completedon Apr 16, 2024
  25. melvin-bot
    removed
    Overdue
    on Apr 16, 2024
  26. github-project-automation
    moved this from HIGH to CRITICAL in [#whatsnext] #vip-vsbon Apr 16, 2024

  27. JmillsExpensify commented on May 2, 2024

    @JmillsExpensify
    JmillsExpensify
    on May 2, 2024
    Contributor

    $500 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions