Skip to content

Remove PR check that will always fail #38329

Description

@blimpich

When we change helpdot docs the PRs that are created run a deploy to cloudflare check that always fails since we don't want to deploy upon a PR being created, only once it's merged. We should remove this check.

Activity

  1. self-assigned this
    on Mar 14, 2024
  2. added
    ReviewingHas a PR in review
    InternalQAThis pull request required internal QA
    and removed
    ReviewingHas a PR in review
    on Mar 14, 2024
  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 18, 2024
  4. changed the title [-]Remove PR check that will always fail[/-] [+][HOLD for payment 2024-03-25] Remove PR check that will always fail[/+] on Mar 18, 2024
  5. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-25. 🎊

  6. self-assigned this
    on Mar 20, 2024
  7. changed the title [-][HOLD for payment 2024-03-25] Remove PR check that will always fail[/-] [+]Remove PR check that will always fail[/+] on Mar 20, 2024
  8. added
    ReviewingHas a PR in review
    and removed
    ReviewingHas a PR in review
    on Mar 25, 2024
  9. melvin-bot commented on Apr 17, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @marcochavezf, @blimpich eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  10. blimpich commented on Apr 17, 2024

    @blimpich
    ContributorAuthor

    Marco fixed this and it was deployed to production weeks ago. See #38690. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions