Repository navigation
Remove PR check that will always fail #38329
Copy link
Copy link
Closed
Labels
EngineeringInternalQAThis pull request required internal QAThis pull request required internal QAMonthlyKSv2KSv2ReviewingHas a PR in reviewHas a PR in reviewTask
Description
Activity
- addedReviewingHas a PR in reviewHas a PR in reviewInternalQAThis pull request required internal QAThis pull request required internal QAWeeklyKSv2KSv2and removedDailyKSv2KSv2ReviewingHas a PR in reviewHas a PR in review
on Mar 14, 2024 - addedWeeklyKSv2KSv2Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionand removedWeeklyKSv2KSv2
on Mar 18, 2024 - changed the title
[-]Remove PR check that will always fail[/-][+][HOLD for payment 2024-03-25] Remove PR check that will always fail[/+]on Mar 18, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-25. 🎊
- changed the title
[-][HOLD for payment 2024-03-25] Remove PR check that will always fail[/-][+]Remove PR check that will always fail[/+]on Mar 20, 2024 - removedAwaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to production
on Mar 20, 2024 - addedReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2and removedWeeklyKSv2KSv2
on Mar 20, 2024 - addedReviewingHas a PR in reviewHas a PR in reviewand removedReviewingHas a PR in reviewHas a PR in review
on Mar 25, 2024 This issue has not been updated in over 15 days. @marcochavezf, @blimpich eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Marco fixed this and it was deployed to production weeks ago. See #38690. Closing.
Metadata
Metadata
Assignees
Labels
EngineeringInternalQAThis pull request required internal QAThis pull request required internal QAMonthlyKSv2KSv2ReviewingHas a PR in reviewHas a PR in reviewTask
When we change helpdot docs the PRs that are created run a deploy to cloudflare check that always fails since we don't want to deploy upon a PR being created, only once it's merged. We should remove this check.