Repository navigation
[Wave Collect] [Workflows] Authorized payer - Admin list is blank if Members tab is not visited before #38290
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Found when validating PR : #38221
Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
- User is an owner of Collect workspace.
- There is at least another admin in the workspace.
- Bank account is set up in "Make or track payments" and there is an authorized payer.
- User has NOT visited Collect workspace member page (rlogin if visited).
- Go to staging.new.expensify.com.
- Go to Profile > Workspaces > Collect workspace.
- Go to Workflows (if it does not appear in side bar, go to More features to trigger it).
- Click Authorized payer under Make or track payments.
- Note that the list is empty.
- Go to Members tab.
- Return to Workflows > Authorized payer.
Expected Result:
In Step 4, the list of admins will show up in Authorized payer RHP.
Actual Result:
In Step 4, the list of admins does not show up in Authorized payer RHP.
It only shows up (Step 7) after members page is rendered in Step 6.
On production, the list shows up without visiting Members tab.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6413044_1710384885994.bandicam_2024-03-14_10-42-21-436.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01f3ab1c1e1a527e48
- Upwork Job ID: 1768267208532287488
- Last Price Increase: 2024-03-14
Activity
melvin-bot commentedon Mar 14, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 14, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 14, 2024
Triggered auto assignment to @Beamanator (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.izarutskaya commentedon Mar 14, 2024
@Beamanator I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Mar 14, 2024
We think that this bug might be related to #wave-control
CC @jason
9 remaining items
mountiny commentedon Mar 14, 2024
This is not a blocker as these are new feature
I think this needs to be internal because we need to load the policy members when the page is loaded
ikevin127 commentedon Mar 14, 2024
Offending PR: #37629 - which is still within the regression period (deployed to production 17h ago, see #37629 (comment)).
I confirm and agree that we're missing thegetWorkspaceMembers()call which we do call when loading the Members page -> reason why we see the list populated after visiting the Members page.luacmartins commentedon Mar 14, 2024
cc @lakchote seems like we also need to load the list of members in
OpenPolicyWorkflowsPageluacmartins commentedon Mar 14, 2024
Got this draft PR - https://github.com/Expensify/Auth/pull/10212
luacmartins commentedon Mar 14, 2024
I don't think this is the right solution since it'd make 2 API calls. The fix is in the backend.
MitchExpensify commentedon Mar 19, 2024
Not overdue Melvin, @luacmartins is working on the backend fix here https://github.com/Expensify/Auth/pull/10212
luacmartins commentedon Mar 20, 2024
PR in review!
trjExpensify commentedon Apr 2, 2024
Can we close this? The linked AuthPR hit prod last week.
luacmartins commentedon Apr 2, 2024
Yea, good to close