Skip to content

[Ideal Nav] WS switcher - Delayed transition of breadcrumbs from Workspace / Chat to Expensify / Chat #38281

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

  • There are at least two workspaces.
  • One of the workspaces has other members,
  1. Go to staging.new.expensify.com.
  2. Open workspace switcher > Select a workspace.
  3. Go to Profile > Workspaces.
  4. Select a different workspace that has members.
  5. Go to Members.
  6. Click on the invited members > Message .

Expected Result:

The breadcrumbs (Expensify / Chat) will sync with the changes in LHN.

Actual Result:

LHN shows all the chats first, then followed by the change of breadcrumbs (Workspace / Chat) to Expensify / Chat. The transition is not smooth.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6412965_1710378599220.bandicam_2024-03-14_09-00-00-162.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 14, 2024
  2. melvin-bot commented on Mar 14, 2024

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. github-actions commented on Mar 14, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Mar 14, 2024

    @melvin-bot

    Triggered auto assignment to @techievivek (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. izarutskaya commented on Mar 14, 2024

    @izarutskaya
    Author

    @techievivek I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Mar 14, 2024

    @izarutskaya
    Author

    We think that this bug might be related to #wave-collect - Release 1
    CC @trjExpensify

  7. techievivek commented on Mar 14, 2024

    @techievivek
    Contributor

    Doesn't need to be a blocker but I am checking the diff to figure out which PR could have caused this regression.

  8. techievivek commented on Mar 14, 2024

    @techievivek
    Contributor

    Also, I can see there is a slight delay but not sure if this is due to some recent PR.

  9. 72 remaining items

  10. self-assigned this
    on May 17, 2024
  11. alexpensify commented on May 17, 2024

    @alexpensify
    Contributor

    Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.

    @trjExpensify - While I'm offline, I need help here completing the payment process after this one clears the 7-day period. That said, it looks like the PR created regression, so we need to address that asap. Thanks!

  12. parasharrajat commented on May 18, 2024

    @parasharrajat
    Member

    PR is merged.

  13. melvin-bot commented on May 24, 2024

    @melvin-bot

    @alexpensify, @trjExpensify, @parasharrajat, @techievivek, @WojtekBoman Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. melvin-bot commented on May 28, 2024

    @melvin-bot

    @alexpensify, @trjExpensify, @parasharrajat, @techievivek, @WojtekBoman 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  15. trjExpensify commented on May 28, 2024

    @trjExpensify
    Contributor

    Dropping off and handing this back to Al.

  16. removed their assignment
    on May 28, 2024
  17. alexpensify commented on May 28, 2024

    @alexpensify
    Contributor

    Noted, I'm going through my BZ batch soon and was planning to grab this one back.

  18. alexpensify commented on May 28, 2024

    @alexpensify
    Contributor

    Ok, I need to start the payment process tomorrow. Looking at the PR, it was merged on May 22.

  19. alexpensify commented on May 29, 2024

    @alexpensify
    Contributor

    Alright, keeping the summary as is since this was a more complicated PR and was quickly addressed:

    #38281 (comment)

    @parasharrajat please submit the request in Chat.

  20. parasharrajat commented on Jun 14, 2024

    @parasharrajat
    Member

    Payment requested as per #38281 (comment)

  21. JmillsExpensify commented on Jun 17, 2024

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat per this summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions