[HOLD for payment 2024-04-15] [$500] [HIGH] When mentioning a user the "actionable whisper" message shows the full display name

@quinthar

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.50-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710108211692399

Action Performed:

Open any room
mention someone in the compose box and send
Look at the "actionable whisper" message Heads up, @B B isn't a member of this room.

Expected Result:

This shouldn't show full display name

Actual Result:

Shows full display name

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Recording.2836.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01c8171385c92b3a6a
Upwork Job ID: 1767266276761448448
Last Price Increase: 2024-03-18
Automatic offers:

ahmedGaber93 | Contributor | 0

@adelekennedy

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When mentioning a user the "actionable whisper" message shows the full display name.

What is the root cause of that problem?

displayName is used here, which leads to the full display name being shown.

App/src/libs/PersonalDetailsUtils.ts

Lines 205 to 211 in 9447937

    
           function getEffectiveDisplayName(personalDetail?: PersonalDetails): string | undefined { 
        
               if (personalDetail) { 
        
                   return LocalePhoneNumber.formatPhoneNumber(personalDetail?.login ?? '') || personalDetail.displayName; 
        
               } 
        
               return undefined; 
        
           }

What changes do you think we should make in order to solve the problem?

firstName should be used.

function getEffectiveDisplayName(personalDetail?: PersonalDetails): string | undefined {
    if (personalDetail) {
        return LocalePhoneNumber.formatPhoneNumber(personalDetail?.login ?? '') || personalDetail.firstName;
    }

    return undefined;
}

Job added to Upwork: https://www.upwork.com/jobs/~01c8171385c92b3a6a

@sobitneupane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@sobitneupane

Expected Result:
This shouldn't show full display name

what is the correct result then? @sobitneupane @quinthar

Proposal

Please re-state the problem that we are trying to solve in this issue.

When mentioning a user the "actionable whisper" message shows the full display name.

What is the root cause of that problem?

displayName is used here, which leads to the full display name being shown.

App/src/libs/PersonalDetailsUtils.ts

Lines 205 to 211 in 9447937

function getEffectiveDisplayName(personalDetail?: PersonalDetails): string | undefined {

if (personalDetail) {

return LocalePhoneNumber.formatPhoneNumber(personalDetail?.login ?? '') || personalDetail.displayName;

}

return undefined;

}

What changes do you think we should make in order to solve the problem?

firstName should be used.
function getEffectiveDisplayName(personalDetail?: PersonalDetails): string | undefined {
    if (personalDetail) {
        return LocalePhoneNumber.formatPhoneNumber(personalDetail?.login ?? '') || personalDetail.firstName;
    }

    return undefined;
}

The problem at hand involves the "actionable whisper" message displaying the full user's display name when mentioning them.

The root cause of this issue lies in the use of the displayName attribute in the getEffectiveDisplayName function, which results in the presentation of the complete display name instead of the intended behavior. The function relies on LocalePhoneNumber.formatPhoneNumber for formatting or defaults to the firstName of the personal details if available.

@ahmedGaber93

Payouts due:

Contributor: $500 @ahmedGaber93 (Upwork)
Contributor+: $500 @sobitneupane (NewDot)

Upwork job is here.

@sobitneupane

Payment summary above - just pending checklist if relevant @sobitneupane !

@sobitneupane

@sobitneupane bump on the checklist.

@sobitneupane

@sobitneupane will you complete the checklist today so we can close?

@sobitneupane

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#36998

[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#36998 (comment)

[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

[@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#38079 (comment)

Regression Test Proposal:

Open any room
Mention someone who is not the room
Notice the "actionable whisper" message
Verify that login is displayed both in mention and actionable whisper.

@sobitneupane

@sobitneupane Thank you!

https://github.com/Expensify/Expensify/issues/390576

@sobitneupane

$500 approved for @sobitneupane

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-15] [$500] [HIGH] When mentioning a user the "actionable whisper" message shows the full display name #38079

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

79 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function getEffectiveDisplayName(personalDetail?: PersonalDetails): string \| undefined {
	if (personalDetail) {
	return LocalePhoneNumber.formatPhoneNumber(personalDetail?.login ?? '') \|\| personalDetail.displayName;
	}

	return undefined;
	}

[HOLD for payment 2024-04-15] [$500] [HIGH] When mentioning a user the "actionable whisper" message shows the full display name #38079

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 11, 2024

ShridharGoel commented on Mar 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Mar 11, 2024

melvin-bot commented on Mar 11, 2024

abzokhattab commented on Mar 11, 2024

whitestar613910 commented on Mar 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

79 remaining items

adelekennedy commented on Apr 15, 2024

adelekennedy commented on Apr 15, 2024

puneetlath commented on Apr 17, 2024

adelekennedy commented on Apr 22, 2024

sobitneupane commented on Apr 24, 2024

sobitneupane commented on Apr 24, 2024

adelekennedy commented on Apr 24, 2024

JmillsExpensify commented on May 12, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions