You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online #38065
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@bondydaa I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Chat - Message sent while offline appears on compose box when user is back online[/-][+][$500] Chat - Message sent while offline appears on compose box when user is back online[/+]on Mar 11, 2024
changed the title [-][$500] Chat - Message sent while offline appears on compose box when user is back online[/-][+][HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/+]on Mar 11, 2024
changed the title [-][HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/-][+][HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/+]on Mar 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
[@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mkhutornyi] Determine if we should create a regression test for this bug.
[@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/-][+][HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/+]on Mar 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
[@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mkhutornyi] Determine if we should create a regression test for this bug.
[@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
github-actions commentedon Mar 11, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 11, 2024
Triggered auto assignment to @bondydaa (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Mar 11, 2024
@bondydaa I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 11, 2024
We think that this bug might be related to #vip-vsp
CC @quinthar
bondydaa commentedon Mar 11, 2024
looks like I was able to reproduce with some text other than
testas well.I did have to log in with a gmail account though, couldn't reproduce on my expensifail.com account.
I wonder if it's any public email?
bondydaa commentedon Mar 11, 2024
I'm pretty sure this would be something in new dot so a contributor should be able to handle, going to add the external label.
[-]Chat - Message sent while offline appears on compose box when user is back online[/-][+][$500] Chat - Message sent while offline appears on compose box when user is back online[/+]melvin-bot commentedon Mar 11, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0116aafb00f186ff86
32 remaining items
[-][$500] Chat - Message sent while offline appears on compose box when user is back online[/-][+][HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/+][-][HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/-][+][HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/+]melvin-bot commentedon Mar 12, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 12, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-19. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 12, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/-][+][HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/+]melvin-bot commentedon Mar 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 13, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
twisterdotcom commentedon Mar 14, 2024
Paid: #38065 (comment)