Skip to content

[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online #38065

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.50-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4413864
Email or phone of affected tester (no customers): vdargentotest+mweb031124@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Pre-requisite: user must be logged in with Gmail account (important)

  1. Go to any chatThe message should be sent and should not remain on the compose box
  2. Disable internet connection
  3. Send the message "Testing" (must be this message or something with "Test" on it)
  4. Verify it appears grayed out
  5. Reload the page
  6. Enable internet connection
  7. Reload the page again

Expected Result:

The message should be sent and should not remain on the compose box

Actual Result:

The message is sent but remains on the compose box

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6409822_1710172524954.Lgyp9954_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0116aafb00f186ff86
  • Upwork Job ID: 1767240869024415744
  • Last Price Increase: 2024-03-11
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. github-actions commented on Mar 11, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Mar 11, 2024

    @melvin-bot

    Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Mar 11, 2024

    @lanitochka17
    Author

    @bondydaa I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Mar 11, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  5. bondydaa commented on Mar 11, 2024

    @bondydaa
    Contributor

    looks like I was able to reproduce with some text other than test as well.

    image

    I did have to log in with a gmail account though, couldn't reproduce on my expensifail.com account.

    I wonder if it's any public email?

  6. bondydaa commented on Mar 11, 2024

    @bondydaa
    Contributor

    I'm pretty sure this would be something in new dot so a contributor should be able to handle, going to add the external label.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 11, 2024
  8. changed the title [-]Chat - Message sent while offline appears on compose box when user is back online[/-] [+][$500] Chat - Message sent while offline appears on compose box when user is back online[/+] on Mar 11, 2024
  9. melvin-bot commented on Mar 11, 2024

    @melvin-bot
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 11, 2024
  11. 32 remaining items

  12. changed the title [-][$500] Chat - Message sent while offline appears on compose box when user is back online[/-] [+][HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/+] on Mar 11, 2024
  13. changed the title [-][HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/-] [+][HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/+] on Mar 12, 2024
  14. melvin-bot commented on Mar 12, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Mar 12, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-19. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mkhutornyi requires payment (Needs manual offer from BZ)
  16. melvin-bot commented on Mar 12, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
    • [@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mkhutornyi] Determine if we should create a regression test for this bug.
    • [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. changed the title [-][HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/-] [+][HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [HOLD for payment 2024-03-11] [$500] Chat - Message sent while offline appears on compose box when user is back online[/+] on Mar 13, 2024
  18. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-20. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mkhutornyi requires payment (Needs manual offer from BZ)
  19. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
    • [@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mkhutornyi] Determine if we should create a regression test for this bug.
    • [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  20. twisterdotcom commented on Mar 14, 2024

    @twisterdotcom
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions