Skip to content

[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [$500] Chat - New messages button is not shown after marking message as unread and scrolling up #38062

Closed
Closed
[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [$500] Chat - New messages button is not shown after marking message as unread and scrolling up#38062
Assignees
marcochavezfmallenexpensifyjayeshmangwani
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Description

@lanitochka17
lanitochka17
opened on Mar 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.50-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4412893
Issue reported by: Applause - Internal Team

Action Performed:

  1. Log in to New Expensify
  2. Navigate to any chat with existing chat history
  3. Mark any message as unread
  4. Scroll up chat history

Expected Result:

New messages button below chat header should be displayed

Actual Result:

New messages button is not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6409859_1710174171308.2024-03-11_17-21-16.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01dc5aa44b04fa24d0
  • Upwork Job ID: 1767281088113135616
  • Last Price Increase: 2024-03-11

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 11, 2024

  2. melvin-bot commented on Mar 11, 2024

    @melvin-bot
    melvin-botBot
    on Mar 11, 2024 – with Melvin Bot

    Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot
    assigned
    mallenexpensify
    on Mar 11, 2024
  4. melvin-bot
    added
    DailyKSv2
    on Mar 11, 2024
  5. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Mar 11, 2024

  6. github-actions commented on Mar 11, 2024

    @github-actions
    github-actionsBot
    on Mar 11, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot
    assigned
    marcochavezf
    on Mar 11, 2024

  8. melvin-bot commented on Mar 11, 2024

    @melvin-bot
    melvin-botBot
    on Mar 11, 2024 – with Melvin Bot

    Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  9. lanitochka17 commented on Mar 11, 2024

    @lanitochka17
    lanitochka17
    on Mar 11, 2024
    Author

    We think that this bug might be related to #vip-vsp
    CC @quinthar

  10. lanitochka17 commented on Mar 11, 2024

    @lanitochka17
    lanitochka17
    on Mar 11, 2024
    Author

    @marcochavezf FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  11. marcochavezf commented on Mar 11, 2024

    @marcochavezf
    marcochavezf
    on Mar 11, 2024
    Contributor

    I couldn't reproduce it on an early commit, so it's external. I'm going to apply the label and I'm still looking for the offending PR

  12. marcochavezf
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 11, 2024

  13. 23 remaining items

  14. melvin-bot commented on Mar 12, 2024

    @melvin-bot
    melvin-botBot
    on Mar 12, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
    • [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jayeshmangwani] Determine if we should create a regression test for this bug.
    • [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  15. mallenexpensify commented on Mar 13, 2024

    @mallenexpensify
    mallenexpensify
    on Mar 13, 2024
    Contributor

    Thanks for the help here @marcochavezf ! Can we close this since the PR was CPd to production?

  16. marcochavezf commented on Mar 13, 2024

    @marcochavezf
    marcochavezf
    on Mar 13, 2024
    Contributor

    Yup, closing it out

  17. marcochavezf
    closed this as completedon Mar 13, 2024
  18. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Mar 13, 2024
  19. melvin-bot
    changed the title [-][HOLD for payment 2024-03-19] [$500] Chat - New messages button is not shown after marking message as unread and scrolling up[/-] [+][HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] [$500] Chat - New messages button is not shown after marking message as unread and scrolling up[/+] on Mar 13, 2024

  20. melvin-bot commented on Mar 13, 2024

    @melvin-bot
    melvin-botBot
    on Mar 13, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-03-20. 🎊

    For reference, here are some details about the assignees on this issue:

  21. melvin-bot commented on Mar 13, 2024

    @melvin-bot
    melvin-botBot
    on Mar 13, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
    • [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@jayeshmangwani] Determine if we should create a regression test for this bug.
    • [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  22. jayeshmangwani commented on Mar 20, 2024

    @jayeshmangwani
    jayeshmangwani
    on Mar 20, 2024
    Contributor

    This issue was closed without the C+ compensation , reviewed this PR , can you please help with this @mallenexpensify

  23. mallenexpensify commented on Mar 22, 2024

    @mallenexpensify
    mallenexpensify
    on Mar 22, 2024
    Contributor

    eeeeps, forgot to pay @jayeshmangwani , sorry about that.
    can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~01dc5aa44b04fa24d0

  24. mallenexpensify
    reopened this on Mar 22, 2024

  25. jayeshmangwani commented on Mar 22, 2024

    @jayeshmangwani
    jayeshmangwani
    on Mar 22, 2024
    Contributor

    Thanks @mallenexpensify , job accepted

  26. mallenexpensify commented on Mar 22, 2024

    @mallenexpensify
    mallenexpensify
    on Mar 22, 2024
    Contributor

    Contributor+: @jayeshmangwani paid $500 via Upwork.

  27. mallenexpensify
    closed this as completedon Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions