Skip to content

LOW: [HOLD for payment 2024-03-20] [$500] [Performance] Decrease the render count of the ReportActionItem and ReportActionItemParentAction #38046

Closed

Description

@mountiny

### Problem

Based on the part of analysis for ReportScreen load time, the ReportActionItem and ReportActionItemParentAction components subscribes to props in unoptimised (duplicated) way, causing components to re-render more times than needed.

### Solution
The props management of those components can be simplified by using props provided directly by components higher in the tree, instead of redundantly subscribing to changes via Onyx HOC.
Here is a PR that introduces those changes.

@kacper-mikolajczak

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013936b6e316c04b02
  • Upwork Job ID: 1767192847195631616
  • Last Price Increase: 2024-03-11
  • Automatic offers:
    • shubham1206agra | Reviewer | 0
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 11, 2024
  2. self-assigned this
    on Mar 11, 2024
  3. melvin-bot commented on Mar 11, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. kacper-mikolajczak commented on Mar 11, 2024

    @kacper-mikolajczak
    Contributor

    👋

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 11, 2024
  6. changed the title [-][Performance] Decrease the render count of the ReportActionItem and ReportActionItemParentAction[/-] [+][$500] [Performance] Decrease the render count of the ReportActionItem and ReportActionItemParentAction[/+] on Mar 11, 2024
  7. melvin-bot commented on Mar 11, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 11, 2024
  9. melvin-bot commented on Mar 11, 2024

    @melvin-bot

    Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

  10. 24 remaining items

  11. shubham1206agra commented on Apr 17, 2024

    @shubham1206agra
    Contributor

    @JmillsExpensify You can process payment here now.

  12. shubham1206agra commented on Apr 23, 2024

    @shubham1206agra
    Contributor

    @JmillsExpensify Bump here.

  13. shubham1206agra commented on May 8, 2024

    @shubham1206agra
    Contributor

    @JmillsExpensify Bump for the payment.

  14. changed the title [-][HOLD for payment 2024-03-20] [$500] [Performance] Decrease the render count of the ReportActionItem and ReportActionItemParentAction[/-] [+]LOW: [HOLD for payment 2024-03-20] [$500] [Performance] Decrease the render count of the ReportActionItem and ReportActionItemParentAction[/+] on May 12, 2024
  15. shubham1206agra commented on May 13, 2024

    @shubham1206agra
    Contributor

    @JmillsExpensify Bump here.

  16. melvin-bot commented on May 13, 2024

    @melvin-bot

    @JmillsExpensify, @mountiny, @shubham1206agra, @kacper-mikolajczak Eep! 4 days overdue now. Issues have feelings too...

  17. JmillsExpensify commented on May 15, 2024

    @JmillsExpensify
    Contributor

    I don't see an active offer link in Upwork, so I just sent you a new one.

  18. shubham1206agra commented on May 15, 2024

    @shubham1206agra
    Contributor
  19. JmillsExpensify commented on May 15, 2024

    @JmillsExpensify
    Contributor

    All paid out. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions