Skip to content

[HOLD for payment 2024-04-15] [Violations] [$500] Multilevel tags - "no longer valid" violation is shown after selecting all the tags #38044

Closed
Closed
[HOLD for payment 2024-04-15] [Violations] [$500] Multilevel tags - "no longer valid" violation is shown after selecting all the tags#38044
Assignees
cead22FitseTLTlaurenreidexpensifydukenv0307
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@kavimuru
kavimuru
opened on Mar 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.50-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

  • User is an employee of Collect workspaces that have independent and dependent multilevel tags.
  • Tag requirement is toggled on.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a manual request without tags.
  4. Go to request details page.
  5. Select all the tags.

Expected Result:

Tag violation will disappear after selecting the tags.

Actual Result:

After selecting all the tag, the last tag shows "no longer valid".

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6409633_1710163056343.20240311_211507.mp4

Bug6409633_1710163006169!independant_tag.csv

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @dukenv0307
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e30e5ceb96930999
  • Upwork Job ID: 1767604738588979200
  • Last Price Increase: 2024-03-19
  • Automatic offers:
    • dukenv0307 | Contributor | 0
    • FitseTLT | Contributor | 0

Activity

  1. kavimuru
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 11, 2024

  2. melvin-bot commented on Mar 11, 2024

    @melvin-bot
    melvin-botBot
    on Mar 11, 2024 – with Melvin Bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot
    assigned
    laurenreidexpensify
    on Mar 11, 2024
  4. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Mar 11, 2024

  5. github-actions commented on Mar 11, 2024

    @github-actions
    github-actionsBot
    on Mar 11, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot
    assigned
    grgia
    on Mar 11, 2024

  7. melvin-bot commented on Mar 11, 2024

    @melvin-bot
    melvin-botBot
    on Mar 11, 2024 – with Melvin Bot

    Triggered auto assignment to @grgia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  8. kavimuru commented on Mar 11, 2024

    @kavimuru
    kavimuru
    on Mar 11, 2024
    Author

    @grgia FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  9. kavimuru commented on Mar 11, 2024

    @kavimuru
    kavimuru
    on Mar 11, 2024
    Author

    We think this bug might be related to #wave6-collect-submitters. cc @greg-schroeder

  10. grgia commented on Mar 11, 2024

    @grgia
    grgia
    on Mar 11, 2024
    Contributor

    Maybe related to #37461

  11. grgia commented on Mar 11, 2024

    @grgia
    grgia
    on Mar 11, 2024
    Contributor

    Asked in slack https://expensify.slack.com/archives/C07J32337/p1710167047439949

  12. 53 remaining items

  13. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Apr 8, 2024

    @melvin-bot
    melvin-botBot
    on Apr 8, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
    • [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@dukenv0307] Determine if we should create a regression test for this bug.
    • [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Apr 14, 2024

  17. laurenreidexpensify commented on Apr 15, 2024

    @laurenreidexpensify
    laurenreidexpensify
    on Apr 15, 2024
    Contributor

    Payment Summary:

  18. laurenreidexpensify commented on Apr 15, 2024

    @laurenreidexpensify
    laurenreidexpensify
    on Apr 15, 2024
    Contributor

    Waiting on @dukenv0307 to complete checklist and confirm regression steps

  19. melvin-bot
    added
    Overdue
    on Apr 16, 2024
  20. laurenreidexpensify
    removed
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Apr 17, 2024

  21. laurenreidexpensify commented on Apr 17, 2024

    @laurenreidexpensify
    laurenreidexpensify
    on Apr 17, 2024
    Contributor

    Bump for checklist @dukenv0307

  22. melvin-bot
    removed
    Overdue
    on Apr 17, 2024

  23. dukenv0307 commented on Apr 19, 2024

    @dukenv0307
    dukenv0307
    on Apr 19, 2024
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR: N/A
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. No
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

  24. dukenv0307 commented on Apr 19, 2024

    @dukenv0307
    dukenv0307
    on Apr 19, 2024
    Contributor

    @laurenreidexpensify Sorry for the delay. I completed the checklist ^

  25. laurenreidexpensify
    closed this as completedon Apr 19, 2024
  26. github-project-automation
    moved this from Release 1: Spring 2024 (May) to Done in #expensify-bugson Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions