[HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating PR : #37457

Version Number: v1.4.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+ihchat4_2902_c@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-requisite: an admin account with a policyExpenseChat enabled Collect policy and another workspace.

1. Open the app
2. Login with admin account with Collect policy
3. Navigate to Workspace > Settings and select the collect policy.
4. Select the Categories page
5. Verify that you see the loading spinner

Expected Result:

Categories load with loading spinner

Actual Result:

Categories load without loading spinner

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2024-03-07.16.27.56.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01197fc8d66a9362f0
• Upwork Job ID: 1770919042911531008
• Last Price Increase: 2024-03-21
• Automatic offers:
• DylanDylann | Reviewer | 0
• GandalfGwaihir | Contributor | 0

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories load without loading spinner

What is the root cause of that problem?

We have loading spinner logic on the page, but we only check if the policyCategories are undefined, but these can be null, before fetching. Since isLoading isn't true when it is null. No loading spinner is shown

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 172 to 178 in c270b5e

	{isLoading && (
	<ActivityIndicator
	size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE}
	style={[styles.flex1]}
	color={theme.spinner}
	/>
	)}

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 128 in c270b5e

const isLoading = !isOffline && policyCategories === undefined;

What changes do you think we should make in order to solve the problem?

We should add a check for if policyCategories are null here

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 128 in c270b5e

const isLoading = !isOffline && policyCategories === undefined;

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories load without loading spinner

What is the root cause of that problem?

We have !isLoading set for the state where the categories are empty:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 179 to 180 in c270b5e

	{categoryList.length === 0 && !isLoading && (
	<WorkspaceEmptyStateSection

But we don't have a !isLoading state for when we list of categories:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 186 to 187 in c270b5e

	{categoryList.length > 0 && (
	<SelectionList

What changes do you think we should make in order to solve the problem?

We need to add a !isLoading parameter to the list:

{categoryList.length > 0 && !isLoading && (
                        <SelectionList

What alternative solutions did you explore? (Optional)

N/A

[alexpensify]

I'll test early next week and we can figure out the next steps. Thanks!

[melvin-bot]

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alexpensify]

No update yet, I need to test.

[allgandalf]

bump @alexpensify for review

[alexpensify]

I've started a discussion in the wave room related to Collect - https://expensify.slack.com/archives/C036QM0SLJK/p1710357619580229. I should have an update by tomorrow.