[HOLD for payment 2024-04-03] [$500] Collect approver - "Waiting for you to pay these expenses" is briefly displayed for approver

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.48-8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• The Collect workspace has admin, employee and a non-reimburser approver.
• Workspace has direct reimbursement.

1. [Employee] Go to workspace chat.
2. {Employee] Create a manual request and submit it.
3. [Approver] Go to workspace chat with employee.
4. [Approver] Click on the expense preview to go to expense report.
5. [Approver] Click Approve.

Expected Result:

The Next step message should only show "Waiting for your admin to pay these expenses".

Actual Result:

The Next step message briefly shows "Waiting for you to pay these expenses" after approving the report, which is a message meant for reimburser.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6404828_1709778120135.20240307_101241.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0126815d05bb2e844f
• Upwork Job ID: 1765765668601966592
• Last Price Increase: 2024-03-07

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[m-natarajan]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think that this bug might be related to #wave6-collect-submitters
cc @greg-schroeder

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Next step message briefly shows "Waiting for you to pay these expenses" after approving the report, which is a message meant for reimburser.

What is the root cause of that problem?

When we built the next step for the approved case we returned the wrong next step message for the case the approver isn't the owner of the request

App/src/libs/NextStepUtils.ts

Line 278 in ffa731a

if (!isOwner) {

What changes do you think we should make in order to solve the problem?

In this case, we should return your admin here instead of you

App/src/libs/NextStepUtils.ts

Line 278 in ffa731a

if (!isOwner) {

OPTIONAL: We can add a check if the approver is an admin we still can return you otherwise return your admin

What alternative solutions did you explore? (Optional)

NA

[dragnoir]

@m-natarajan @mallenexpensify any idea how to create a non-reimburser approver account?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0126815d05bb2e844f

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)