Skip to content

[HOLD for payment 2024-06-28] [MEDIUM] Create Trip Room Preview #37826

Closed
Closed
[HOLD for payment 2024-06-28] [MEDIUM] Create Trip Room Preview#37826
Assignees
twisterdotcomgrgiastitesExpensifyWojtekBomanshubham1206agrasmelaa
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringWeeklyKSv2

Description

@stitesExpensify
stitesExpensify
opened on Mar 6, 2024

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: [#whatsnext] #Travel
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.6c8m84z62q6z

This issue is for creating another new preview type, this time for trip rooms:
2024-03-06_08-39-00

  • A new component, TripRoomPreview will be created in src/components/ReportActionItem.
  • A new action type, ACTION_TRIPPREVIEW, will be added to CONST.ts.
  • If the report action is of the new type, which we will check in ReportActionItem.js, the new component will be displayed.
  • TripRoomPreview will mimic ReportPreview’s formatting and behavior with some notable changes:
    • We’ll display the room name under the total
  • Receipts will not be displayed.
  • Instead, a new helper function, getTripTransactions(expenseReportID) will be created in ReportUtils, and will return any transaction with travel details. We’ll display those details as shown in the mockup.
  • On click, it’ll take the user to the trip room via Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID));
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. stitesExpensify
    added
    Engineering
    DailyKSv2
    on Mar 6, 2024
  2. stitesExpensify
    assigned
    twisterdotcom
    on Mar 6, 2024
  3. stitesExpensify
    added this to [#whatsnext] #Travelon Mar 6, 2024
  4. twisterdotcom
    moved this to Critical - V1 in [#whatsnext] #Travelon Mar 6, 2024

  5. WojtekBoman commented on Mar 8, 2024

    @WojtekBoman
    WojtekBoman
    on Mar 8, 2024
    Contributor

    Hey! I’m Wojtek from Software Mansion, the expert agency, and I’d like to work on this issue.

  6. mountiny
    assigned
    WojtekBoman
    on Mar 8, 2024

  7. twisterdotcom commented on Mar 8, 2024

    @twisterdotcom
    twisterdotcom
    on Mar 8, 2024
    Contributor

    Adding a C+ here for Travel reviews: @shubham1206agra

  8. twisterdotcom
    assigned
    shubham1206agra
    on Mar 8, 2024
  9. melvin-bot
    added
    Overdue
    on Mar 11, 2024

  10. twisterdotcom commented on Mar 11, 2024

    @twisterdotcom
    twisterdotcom
    on Mar 11, 2024
    Contributor

    Only assigned on Friday. We can give them a day here Melvin.

  11. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Mar 11, 2024

  12. melvin-bot commented on Mar 14, 2024

    @melvin-bot
    melvin-botbot
    on Mar 14, 2024 – with Melvin Bot

    @twisterdotcom, @WojtekBoman, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. twisterdotcom commented on Mar 14, 2024

    @twisterdotcom
    twisterdotcom
    on Mar 14, 2024
    Contributor

    Are we waiting on anything internal here?

  14. 91 remaining items

  15. melvin-bot
    assigned
    grgia
    on Jun 12, 2024

  16. melvin-bot commented on Jun 12, 2024

    @melvin-bot
    melvin-botbot
    on Jun 12, 2024 – with Melvin Bot

    Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  17. stitesExpensify
    self-assigned this
    on Jun 14, 2024
  18. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    WeeklyKSv2
    on Jun 21, 2024
  19. melvin-bot
    changed the title [-][MEDIUM] Create Trip Room Preview[/-] [+][HOLD for payment 2024-06-28] [MEDIUM] Create Trip Room Preview[/+] on Jun 21, 2024

  20. melvin-bot commented on Jun 21, 2024

    @melvin-bot
    melvin-botbot
    on Jun 21, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  21. melvin-bot
    removed
    ReviewingHas a PR in review
    on Jun 21, 2024

  22. melvin-bot commented on Jun 21, 2024

    @melvin-bot
    melvin-botbot
    on Jun 21, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.0-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-28. 🎊

    For reference, here are some details about the assignees on this issue:

  23. twisterdotcom commented on Jun 28, 2024

    @twisterdotcom
    twisterdotcom
    on Jun 28, 2024
    Contributor

    Payment Summary:

  24. twisterdotcom
    closed this as completedon Jun 28, 2024
  25. github-project-automation
    moved this from Medium - V1.5 to Done in [#whatsnext] #Travelon Jun 28, 2024

  26. shubham1206agra commented on Jun 28, 2024

    @shubham1206agra
    shubham1206agra
    on Jun 28, 2024
    Contributor

    @twisterdotcom This issue was created and assigned before April 6. I think bounty should be $500.

  27. twisterdotcom commented on Jun 28, 2024

    @twisterdotcom
    twisterdotcom
    on Jun 28, 2024
    Contributor

    Thanks! Just updated it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions