Skip to content

[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [MEDIUM] Create new Trip Room #37825

Closed
Closed
[HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [MEDIUM] Create new Trip Room#37825
Assignees
amyevanstwisterdotcomrushatgabhaneWojtekBomanshubham1206agrasmelaa
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Engineering

Description

@stitesExpensify
stitesExpensify
opened on Mar 6, 2024

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: [#whatsnext] #Travel
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.g77lx534xj1g

2024-03-06_07-50-59

A new component, TripDetailsView will be created in src/components/ReportActionItem:

  • It will display and behave mimicking MoneyReportView’s behavior.
  • A new chat type, ​​POLICY_TRIP_ROOM, will be added to CONST.ts.
  • A new helper function, isTripRoom(report) will be added to ReportUtils. It will return true if the provided report type is CONST.REPORT.TYPE.CHAT, and the chat type is the new CONST.REPORT.CHAT_TYPE.​​POLICY_TRIP_ROOM
  • It will be displayed from ReportActionItem if isTripRoom returns true.
  • It will take the associated expense report as parameter and:
  • Use the new getTripTransactions function to retrieve all transactions with trip data to display.
  • Display them as shown above using the existing MenuItemWithTopDescription like we do for money reports.
  • On click, it will open the trip details panel via a new route, ROUTES.TRAVEL_DETAILS

Routes table:
https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.gn6jbl2udlnx

Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. stitesExpensify
    added
    Engineering
    DailyKSv2
    on Mar 6, 2024
  2. stitesExpensify
    assigned
    twisterdotcom
    on Mar 6, 2024
  3. stitesExpensify
    added this to [#whatsnext] #Travelon Mar 6, 2024
  4. twisterdotcom
    moved this to Critical - V1 in [#whatsnext] #Travelon Mar 6, 2024

  5. WojtekBoman commented on Mar 8, 2024

    @WojtekBoman
    WojtekBoman
    on Mar 8, 2024
    Contributor

    Hey! I’m Wojtek from Software Mansion, the expert agency, and I’d like to work on this issue.

  6. mountiny
    assigned
    WojtekBoman
    on Mar 8, 2024

  7. twisterdotcom commented on Mar 8, 2024

    @twisterdotcom
    twisterdotcom
    on Mar 8, 2024
    Contributor

    Adding a C+ here for Travel reviews: @shubham1206agra

  8. twisterdotcom
    assigned
    shubham1206agra
    on Mar 8, 2024
  9. melvin-bot
    added
    Overdue
    on Mar 11, 2024

  10. twisterdotcom commented on Mar 11, 2024

    @twisterdotcom
    twisterdotcom
    on Mar 11, 2024
    Contributor

    Only assigned on Friday. We can give them a day here Melvin.

  11. melvin-bot
    added
    Overdue
    and removed
    Overdue
    on Mar 11, 2024

  12. melvin-bot commented on Mar 14, 2024

    @melvin-bot
    melvin-botbot
    on Mar 14, 2024 – with Melvin Bot

    @twisterdotcom, @WojtekBoman, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. twisterdotcom commented on Mar 14, 2024

    @twisterdotcom
    twisterdotcom
    on Mar 14, 2024
    Contributor

    Are we waiting on anything internal here?

  14. 71 remaining items

  15. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Jun 13, 2024
  16. melvin-bot
    changed the title [-][HOLD for payment 2024-06-18] [MEDIUM] Create new Trip Room[/-] [+][HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [MEDIUM] Create new Trip Room[/+] on Jun 13, 2024

  17. melvin-bot commented on Jun 13, 2024

    @melvin-bot
    melvin-botbot
    on Jun 13, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-20. 🎊

    For reference, here are some details about the assignees on this issue:

  18. rushatgabhane commented on Jun 16, 2024

    @rushatgabhane
    rushatgabhane
    on Jun 16, 2024
    Member

    PR hit production 5 days ago.

  19. rushatgabhane commented on Jun 16, 2024

    @rushatgabhane
    rushatgabhane
    on Jun 16, 2024
    Member

    @shubham1206agra please complete checklist for this one to add regression steps for a new feature.

  20. shubham1206agra commented on Jun 16, 2024

    @shubham1206agra
    shubham1206agra
    on Jun 16, 2024
    Contributor

    @rushatgabhane New feature. No need for a checklist here. I believe tests are being handled separately in the doc.

  21. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Jun 18, 2024

  22. rushatgabhane commented on Jun 19, 2024

    @rushatgabhane
    rushatgabhane
    on Jun 19, 2024
    Member

    @twisterdotcom could you please attach payment summary 🙇

  23. twisterdotcom commented on Jun 20, 2024

    @twisterdotcom
    twisterdotcom
    on Jun 20, 2024
    Contributor

    Payment Summary: ($500 as originally this was CRITICAL):

  24. twisterdotcom
    closed this as completedon Jun 20, 2024
  25. github-project-automation
    moved this from Medium - V1.5 to Done in [#whatsnext] #Travelon Jun 20, 2024

  26. shubham1206agra commented on Jun 20, 2024

    @shubham1206agra
    shubham1206agra
    on Jun 20, 2024
    Contributor

    @twisterdotcom Offer accepted

  27. JmillsExpensify commented on Jun 23, 2024

    @JmillsExpensify
    JmillsExpensify
    on Jun 23, 2024
    Contributor

    $500 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions