[HOLD for payment 2024-04-15] [$500] Task - Mark as complete button shows up on cancelled task report

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.47-0
Reproducible in staging?:. yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to chat.
Create a task.
Click on the task.
Click 3-dot menu > Delete > Delete the task.
Go to the cancelled task report from LHN.

Expected Result:

Mark as complete button will not show up on cancelled task report.

Actual Result:

Mark as complete button shows up on cancelled task report. Clicking on the button leads to error.
On mweb, Android and iOS app, the button appears and disappears after opening the cancelled task report.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6402230_1709602046041.bandicam_2024-03-05_06-02-11-676__3_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0142a0550498bb0d82
Upwork Job ID: 1765856337867956224
Last Price Increase: 2024-03-21
Automatic offers:

situchan | Reviewer | 0
dukenv0307 | Contributor | 0

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@quinthar

We think that this bug might be related to #vip-vsb
cc @quinthar

@Ischurr

@Ischurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mark as complete button shows up on cancelled task report. Clicking on the button leads to error.
On mweb, Android and iOS app, the button appears and disappears after opening the cancelled task report.

What is the root cause of that problem?

When we open the task report, OpenReport API is called and BE returns isDeletedParentAction as null.

It leads to this check being true in HeaderView

App/src/pages/home/HeaderView.js

Line 362 in a79c119

    
           {isTaskReport && !isSmallScreenWidth && ReportUtils.isOpenTaskReport(props.report) && <TaskHeaderActionButton report={props.report} />}

App/src/libs/ReportUtils.ts

Line 671 in a79c119

    
           isTaskReport(report) && !isCanceledTaskReport(report, parentReportAction) && report?.stateNum === CONST.REPORT.STATE_NUM.OPEN && report?.statusNum === CONST.REPORT.STATUS_NUM.OPEN

because we don't pass parentReportAction into isOpenTaskReport task report as we

App/src/pages/home/ReportScreen.js

Line 535 in a79c119

    
           {ReportUtils.isTaskReport(report) && isSmallScreenWidth && ReportUtils.isOpenTaskReport(report, parentReportAction) && (

What changes do you think we should make in order to solve the problem?

We should pass parentReportAction from ReportScreen into HeaderView instead of getting it through getParentReportAction because HeaderView will not re-render if parentReportAction is changed.

App/src/pages/home/HeaderView.js

Line 113 in a79c119

    
           const parentReportAction = ReportActionsUtils.getParentReportAction(props.report);

pass props.parentReportAction into isOpenTaskReport here

{isTaskReport && !isSmallScreenWidth && ReportUtils.isOpenTaskReport(props.report, props.parentReportAction) && <TaskHeaderActionButton report={props.report} />}

App/src/pages/home/HeaderView.js

Line 362 in a79c119

    
           {isTaskReport && !isSmallScreenWidth && ReportUtils.isOpenTaskReport(props.report) && <TaskHeaderActionButton report={props.report} />}

We should get all actions of parent report through another withOnyx and then get the parent report action inside the report screen and then we will update the the memo function to only re-render when the current parent report action is changed.

App/src/pages/home/ReportScreen.tsx

Line 627 in ddf9e7a

parentReportAction: {

What alternative solutions did you explore? (Optional)

NA

Asking in Slack - https://expensify.slack.com/archives/C066HJM2CAZ/p1709658682543139

Job added to Upwork: https://www.upwork.com/jobs/~0142a0550498bb0d82

@situchan

@situchan The PR is ready for review.

Reviewing label has been removed, please complete the "BugZero Checklist".

@situchan

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix mark as complete button shows up on cancelled task report #38991

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

@situchan requires payment automatic offer (Reviewer)
@dukenv0307 requires payment automatic offer (Contributor)

@dukenv0307

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@dukenv0307] Determine if we should create a regression test for this bug.
[@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@dukenv0307

@dukenv0307 - Do we need a regression test for this one?

@dukenv0307

Payment summary:

Contributor: @dukenv0307 $500 (paid in Upwork)
Contributor+: @situchan $500 (paid in Upwork)

Navigation Menu

Repository navigation

[HOLD for payment 2024-04-15] [$500] Task - Mark as complete button shows up on cancelled task report #37707

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

36 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-04-15] [$500] Task - Mark as complete button shows up on cancelled task report #37707

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Mar 5, 2024

m-natarajan commented on Mar 5, 2024

m-natarajan commented on Mar 5, 2024

dukenv0307 commented on Mar 5, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

lschurr commented on Mar 5, 2024

melvin-bot commented on Mar 7, 2024

36 remaining items

dukenv0307 commented on Mar 27, 2024

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 8, 2024

melvin-bot commented on Apr 8, 2024

lschurr commented on Apr 12, 2024

lschurr commented on Apr 15, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions