[PAYMENT DUE APRIL 3RD][$500] Room - Invited user name is not displayed in LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.46
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4359689
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch app
2. Tap fab-Start chat
3. Tap room
4. Enter all details
5. Tap Create room
6. Tap room header
7. Tap members-Invite
8. Invite an user
9. Go to https://staging.new.expensify.com/home
10. Login as invited user
11. Note the invited room chat report in LHN

Expected Result:

Invited user name must be displayed in LHN
Xxx:Invited 1 user must be shown

Actual Result:

Invited user name is not displayed in LHN
Invited 1 user is shown without user name. Xxx(not shown) :Invited 1 user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6399181_1709355699511.fill.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01da2b85a3cfbedea6
• Upwork Job ID: 1766155759412510720
• Last Price Increase: 2024-03-08

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[lanitochka17]

@abekkala FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invited user name is not displayed in LHN
Invited 1 user is shown without user name. Xxx(not shown) :Invited 1 user

What is the root cause of that problem?

We're getting the actor display name in

App/src/libs/OptionsListUtils.ts

Line 524 in 4231ac9

? lastActorDetails.firstName ?? PersonalDetailsUtils.getDisplayNameOrDefault(lastActorDetails)

but in this case lastActorDetails.firstName is '', not undefined so the function behind ?? is not executed.

-> '' is shown

What changes do you think we should make in order to solve the problem?

We should use || in this case instead of ??

What alternative solutions did you explore? (Optional)

NA

Result

[melvin-bot]

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@abekkala Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01da2b85a3cfbedea6