Repository navigation
Android - Workspace - Workspace name is not fully displayed on Profile page #37548
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @hayata-suenaga (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Production:
Recording.2421.mp4
@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #vip-vsp
CC @quintharnot a bug. looks like it's intentional
Reacted by GandalfProposal
Please re-state the problem that we are trying to solve in this issue.
Android - Workspace - Workspace name is not fully displayed on Profile page
What is the root cause of that problem?
App/src/components/MenuItem.tsx
Lines 520 to 528 in c2e24e1
There's no style property incombinedTitleTextStylewhich stretches text to the full width.What changes do you think we should make in order to solve the problem?
add
flex: 1orwidth: '100%'under the condition of(!shouldShowTitleIcon || !titleIcon) &&Note: this is android only issue and same root cause as #21219 or #24339, but this solution (kind of workaround) is already applied in other places of the app. #30023 is a good example
looking at this right now 👀
yep this clearly looks like intentional change.
@lanitochka17 did you have any TestRail case that specify that the workspace name should be fully displayed?
anyway, closing this for now
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): gocemate@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Workspace name should be fully displayed
Actual Result:
Workspace name is not fully displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub