Repository navigation
[No payment] Chat-URL link shown in preview but turned to text after sending message. #37472
Description
Activity
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @nkuoch (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.We think that this bug might be related to #vip-vsb
@nkuoch I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
The parsing differences are caused by different versions of expensify-common used by react-native-live-markdown and App. (I think we should use
peerDependencies)The App includes this latest commit which makes a single character domain (e.g.
j.com) not recognized as a link.Thanks @bernhardoj. cc @aswin-s this is coming from your PR
24 remaining items
Sorry - I just realised that myself
I am going to be OOO on the 7th so assigned Lauren, but all good here. @lschurr I will unassign you
@nkuoch, @miljakljajic Whoops! This issue is 2 days overdue. Let's get this updated quick!
- changed the title
[-][HOLD for payment 2024-03-07] Chat-URL link shown in preview but turned to text after sending message.[/-][+][HOLD for payment 2024-03-11] [HOLD for payment 2024-03-07] Chat-URL link shown in preview but turned to text after sending message.[/+]on Mar 4, 2024 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-11. 🎊
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@nkuoch] The PR that introduced the bug has been identified. Link to the PR: fix: prevent lag when adding code block in task description #36819
- [@nkuoch] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: prevent lag when adding code block in task description #36819 (comment)
- [@nkuoch] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No, we just reverted the original PR so far
- [@nkuoch] Determine if we should create a regression test for this bug. No, we just reverted the original PR so far
- [@nkuoch] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. No, we just reverted the original PR so far
- [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
- changed the title
[-][HOLD for payment 2024-03-11] [HOLD for payment 2024-03-07] Chat-URL link shown in preview but turned to text after sending message.[/-][+][No payment] Chat-URL link shown in preview but turned to text after sending message.[/+]on Mar 6, 2024
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.45
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Action Performed:
Expected Result:
URL link shown in preview and same link format must be shown after sending message.
Actual Result:
URL link shown in preview but turned to text after sending message.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6396611_1709183463397.az_recorder_20240229_074258.mp4
View all open jobs on GitHub